From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55029) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3hd-0001rU-86 for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:31:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW3hU-00070r-3g for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:30:53 -0400 Received: from mail-ob0-x232.google.com ([2607:f8b0:4003:c01::232]:36932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW3hT-0006yj-Py for qemu-devel@nongnu.org; Mon, 22 Sep 2014 09:30:43 -0400 Received: by mail-ob0-f178.google.com with SMTP id va2so3763706obc.37 for ; Mon, 22 Sep 2014 06:30:38 -0700 (PDT) Sender: Corey Minyard Message-ID: <5420247C.9030902@acm.org> Date: Mon, 22 Sep 2014 08:30:36 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1411340664-26912-1-git-send-email-minyard@acm.org> <1411340664-26912-5-git-send-email-minyard@acm.org> <541FD872.8000601@redhat.com> <542020F7.5050906@acm.org> <5420234D.7000505@redhat.com> In-Reply-To: <5420234D.7000505@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: mjg59@srcf.ucam.org, Corey Minyard , hwd@huawei.com, bcketchum@gmail.com, mst@redhat.com, afaerber@suse.de On 09/22/2014 08:25 AM, Paolo Bonzini wrote: > Il 22/09/2014 15:15, Corey Minyard ha scritto: >>>> Why move this from qemu_chr_finish_socket_connection to tcp_chr_connect? >>>> Perhaps move this part of the patch earlier, either just before or just >>>> after patch 2? >> I had to make this change, otherwise a server socket would never show >> that it reconnected. I originally hadn't moved it. > Reconnected or connected? How does reconnection work with server > sockets? I guess you can then move it to patch 2. When a server socket disconnects, it runs through the disconnect code so it shows "disconnected". It does not call qemu_chr_finish_socket_connection when it reconnects, though, so it would never show the new connection. I can move it to patch 2, but it seems more logical to me here, since it doesn't really matter until this patch. Thanks, -corey