From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48325) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW4jT-0002a3-KY for qemu-devel@nongnu.org; Mon, 22 Sep 2014 10:36:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW4jN-0000em-Fm for qemu-devel@nongnu.org; Mon, 22 Sep 2014 10:36:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW4jN-0000eA-7A for qemu-devel@nongnu.org; Mon, 22 Sep 2014 10:36:45 -0400 Message-ID: <54202B0D.8080201@redhat.com> Date: Mon, 22 Sep 2014 15:58:37 +0200 From: Max Reitz MIME-Version: 1.0 References: <1410891148-28849-1-git-send-email-armbru@redhat.com> <1410891148-28849-23-git-send-email-armbru@redhat.com> In-Reply-To: <1410891148-28849-23-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 22/23] block: Lift device model API into BlockBackend List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, benoit.canet@nodalink.com, stefanha@redhat.com On 16.09.2014 20:12, Markus Armbruster wrote: > Move device model attachment / detachment and the BlockDevOps device > model callbacks and their wrappers from BlockDriverState to > BlockBackend. > > Signed-off-by: Markus Armbruster > --- > block.c | 126 ++++------------------------------ > block/block-backend.c | 151 ++++++++++++++++++++++++++++++++++++++--- > block/qapi.c | 8 +-- > blockdev.c | 8 +-- > include/block/block.h | 45 ------------ > include/block/block_int.h | 12 ++-- > include/sysemu/block-backend.h | 35 ++++++++++ > 7 files changed, 203 insertions(+), 182 deletions(-) Reviewed-by: Max Reitz