qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
	"Daniel P. Berrange" <berrange@redhat.com>
Cc: "Ryan Harper" <ryan.harper@canonical.com>,
	"quintela@redhat.com" <quintela@redhat.com>,
	Libvirt <libvir-list@redhat.com>,
	"Serge Hallyn" <serge.hallyn@ubuntu.com>,
	"Alexander Graf" <agraf@suse.de>,
	qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
	"Alex Bligh" <alex@alex.org.uk>,
	"Amit Shah" <amit.shah@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm
Date: Mon, 22 Sep 2014 17:44:42 +0200	[thread overview]
Message-ID: <542043EA.6060104@redhat.com> (raw)
In-Reply-To: <878ulb7k54.fsf@blackfin.pond.sub.org>

Il 22/09/2014 17:24, Markus Armbruster ha scritto:
> You're right.  However, this particular horse left the barn a long time
> ago: the pc-* machine types differ in qemu-kvm and upstream QEMU.
> 
> Sure, when qemu-kvm was merged back into QEMU, its machine type variants
> were dropped.  But they live on in various downstreams that just like
> QEMU had to pick between compatibility with upstream QEMU and qemu-kvm,
> but unlike QEMU picked compatibility with qemu-kvm.

And fixing this should have been downstream's job.  Fedora did it at the
time, RHEL7 did it.  Ubuntu didn't, and probably neither did Debian.

This patch singles out pc-1.0 just because it used to be the default in
Ubuntu 12.04.  So basically it's making upstream carry the burden of a
decision of the Ubuntu folks.  It's understandable that Alex disagrees
with the decision, but nevertheless it's not something that upstream
should agree with.

Also, another horse that has left the barn: it's already too late to
apply this patch to upstream Ubuntu.  If you do that, any machine
created with 12.04 and reused with 14.04 will fail to migrate to another
14.04 machine that includes this patch, as I understand it.

So as things stand, I don't see a reason to apply this patch upstream.

Paolo

  parent reply	other threads:[~2014-09-22 15:45 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-21 14:38 [Qemu-devel] [PATCH v3 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm Alex Bligh
2014-09-21 14:38 ` [Qemu-devel] [PATCH v3 1/2] " Alex Bligh
2014-09-22 11:50   ` Michael S. Tsirkin
2014-09-22 12:28     ` Alex Bligh
2014-09-22 12:38       ` Michael S. Tsirkin
2014-09-21 14:38 ` [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm Alex Bligh
2014-09-22 11:36   ` Michael S. Tsirkin
2014-09-22 11:42     ` [Qemu-devel] [libvirt] " Daniel P. Berrange
2014-09-22 11:53       ` Michael S. Tsirkin
2014-09-22 15:24       ` Markus Armbruster
2014-09-22 15:36         ` Michael S. Tsirkin
2014-09-22 15:47           ` Serge Hallyn
2014-09-22 15:44         ` Paolo Bonzini [this message]
2014-09-22 17:30           ` Alex Bligh
2014-09-22 19:10             ` Paolo Bonzini
2014-09-22 19:36               ` Alex Bligh
2014-09-23  0:12                 ` Serge Hallyn
2014-09-22 11:50     ` [Qemu-devel] " Alex Bligh
2014-09-22 12:10       ` Michael S. Tsirkin
2014-09-22 13:05         ` Alex Bligh
2014-09-22 15:45           ` Andreas Färber
2014-09-22 16:54             ` Alex Bligh
2014-09-22 17:26               ` Markus Armbruster
2014-09-23  3:46               ` Michael S. Tsirkin
2014-09-23  3:44             ` Michael S. Tsirkin
2014-09-22 15:32     ` Markus Armbruster
2014-09-22 17:21       ` Michael S. Tsirkin
2014-09-23  7:59         ` Markus Armbruster
2014-09-23  8:24           ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542043EA.6060104@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=alex@alex.org.uk \
    --cc=amit.shah@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=ryan.harper@canonical.com \
    --cc=serge.hallyn@ubuntu.com \
    --cc=serge@hallyn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).