From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43714)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XW68o-00072B-Vd
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:07:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XW68h-00083a-52
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:07:06 -0400
Received: from cantor2.suse.de ([195.135.220.15]:49902 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1XW68g-0007yv-Ue
	for qemu-devel@nongnu.org; Mon, 22 Sep 2014 12:06:59 -0400
Message-ID: <5420491C.8070905@suse.de>
Date: Mon, 22 Sep 2014 18:06:52 +0200
From: =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1411385195-13495-1-git-send-email-lersek@redhat.com>	<1411385195-13495-3-git-send-email-lersek@redhat.com>	<5420105C.2090701@suse.de>
	<54201614.6040903@redhat.com>	<20140922123641.GB7992@redhat.com>
	<54202100.7020205@redhat.com> <542046E3.8080203@redhat.com>
In-Reply-To: <542046E3.8080203@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] machine_parse(): list supported
 machine types in their registration order
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Laszlo Ersek <lersek@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, marcel.a@redhat.com

Am 22.09.2014 um 17:57 schrieb Paolo Bonzini:
> Il 22/09/2014 15:15, Laszlo Ersek ha scritto:
>> $ git grep -E '\<qemu_register(_pc)?_machine\>' | wc -l
>> 115
>>
>> Even if we just count the clusters, they're way too many:
>>
>> $ git grep -E '\<machine_init\>' | wc -l
>> 66
>=20
> There are just a couple of multi-machine clusters (well, three: pseries=
,
> pc, q35).  So the default clusters can just default to the machine type=
.

I would've gone even simpler and special-cased pc/q35 and "none" (like
we did for -cpu "host") in the comparison function, sparing us any big
interface work.

Therefore from my point of review, this was merely about how we
implement the comparison function. No reason to get a heart attack IMO.

Cheers,
Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg