From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW73h-0007Lu-VU for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:05:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XW73c-0000he-TD for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:05:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XW73c-0000h8-Mh for qemu-devel@nongnu.org; Mon, 22 Sep 2014 13:05:48 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8MH5hAr013133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 22 Sep 2014 13:05:43 -0400 Message-ID: <542056E6.2000300@redhat.com> Date: Mon, 22 Sep 2014 11:05:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411377623-11420-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1411377623-11420-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QkEsDpugMKnAMV5K8rbuiDxqUJwJuOv5I" Subject: Re: [Qemu-devel] [PATCH] docs: add blkdebug block driver documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , John Snow , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --QkEsDpugMKnAMV5K8rbuiDxqUJwJuOv5I Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2014 03:20 AM, Stefan Hajnoczi wrote: > The blkdebug block driver is undocumented. Documenting it is worthwhil= e > since it offers powerful error injection features that are used by > qemu-iotests test cases. >=20 > This document will make it easier for people to learn about and use > blkdebug. >=20 > Signed-off-by: Stefan Hajnoczi > --- > docs/blkdebug.txt | 142 ++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 142 insertions(+) > create mode 100644 docs/blkdebug.txt >=20 > diff --git a/docs/blkdebug.txt b/docs/blkdebug.txt > new file mode 100644 > index 0000000..7e616e0 > --- /dev/null > +++ b/docs/blkdebug.txt > @@ -0,0 +1,142 @@ No worse than many other files in this directory for omitting copyright and license information (which means it inherits the default of GPLv2+ from the top-level). > + > +Rules can be placed in a .ini file: Choice of article depends on whether you pronounce it "a dot-innie" or "an eye-en-eye" file. > + > + $ cat blkdebug.conf This file suffix is not '.ini'. So the idea is more that it is a configuration file that uses '.ini' style parsing, and not that it is an actual '.ini' file. > + [inject-error] > + event =3D "read_aio" > + errno =3D "28" > + > +This rule fails all aio read requests with ENOSPC (28). Eeesh - we are really tying things to host-dependent errno values? Might be worth a paragraph explaining that ENOSPC is not always 28. Or a design improvement to the setup to allow symbolic naming of the desired actions. Or both. > + > + errno - the POSIX errno value to return when a request matches this = rule > + Again, POSIX doesn't proscribe errno values, just symbolic names; and those names differ in values across different OS. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --QkEsDpugMKnAMV5K8rbuiDxqUJwJuOv5I Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUIFbmAAoJEKeha0olJ0NqQwAH/RNrH7vug9U2ZsXvA1GOUsqR hFocFOJS9cA2mdCdPRkgp47d02TMaRP4EW5qyCr+tU7FJC22e8fLj8sibw64bSw3 Or8b0LbMdGTU7B+F1FknRTX15xzxNAmwC+TabqoscEgjFM1H+X+SUhebGfwvaCFR SnLBJloa/MnbL1izkkrg+jHxvrzCVBiJiufcmLUb+rN3sgnneJsPWVtAk6NPPz2C Kw7E2AdKxCXng7A5NVZNb4ynY64X31yBuVWrs5gizytBmB8PsrQJcUF3RH/N65S+ iVfY4KbV8iVEg3CrKWAt8EOvLzphQsyqoqZIePkb/yUoyPCRg8aDW3MXPayzOOg= =3iR9 -----END PGP SIGNATURE----- --QkEsDpugMKnAMV5K8rbuiDxqUJwJuOv5I--