From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] 9pfs: fix inode sequencing in 'synth' driver
Date: Wed, 16 Mar 2022 19:16:24 +0100 [thread overview]
Message-ID: <5420581.RCpjWDn7hV@silver> (raw)
In-Reply-To: <20220316121043.1de4f0a1@bahia>
On Mittwoch, 16. März 2022 12:10:43 CET Greg Kurz wrote:
> On Mon, 14 Mar 2022 19:58:11 +0100
>
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > The 'synth' driver's root node and the 'synth' driver's first
> > subdirectory node falsely share the same inode number (zero), which
> > makes it impossible for 9p clients (i.e. 9p test cases) to distinguish
> > root node and first subdirectory from each other by comparing their QIDs
> > (which are derived by 9p server from driver's inode numbers).
> >
> > Fix this issue by using prefix-increment instead of postfix-increment
> > operator while generating new inode numbers for subdirectories and files.
> >
> > Link: https://lore.kernel.org/qemu-devel/3859307.hTDP4D0zbi@silver/
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
>
> Good catch !
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck
prev parent reply other threads:[~2022-03-16 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 18:58 [PATCH] 9pfs: fix inode sequencing in 'synth' driver Christian Schoenebeck
2022-03-16 11:10 ` Greg Kurz
2022-03-16 18:16 ` Christian Schoenebeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5420581.RCpjWDn7hV@silver \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).