From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33461) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWACC-0000B3-7a for qemu-devel@nongnu.org; Mon, 22 Sep 2014 16:26:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWAC8-0005j9-0r for qemu-devel@nongnu.org; Mon, 22 Sep 2014 16:26:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11334) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWAC7-0005iI-Og for qemu-devel@nongnu.org; Mon, 22 Sep 2014 16:26:47 -0400 Message-ID: <542085FA.2030701@redhat.com> Date: Mon, 22 Sep 2014 14:26:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411405169-820-1-git-send-email-minyard@acm.org> <1411405169-820-6-git-send-email-minyard@acm.org> In-Reply-To: <1411405169-820-6-git-send-email-minyard@acm.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="arfhEHu5tbSSqglbG7O4KgaMg5VxngNwB" Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, qemu-devel@nongnu.org Cc: mjg59@srcf.ucam.org, mst@redhat.com, hwd@huawei.com, bcketchum@gmail.com, Corey Minyard , afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --arfhEHu5tbSSqglbG7O4KgaMg5VxngNwB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/22/2014 10:59 AM, minyard@acm.org wrote: > From: Corey Minyard >=20 > Adds a "reconnect" option to socket backends that gives a reconnect > timeout. This only applies to client sockets. If the other end > of a socket closes the connection, qemu will attempt to reconnect > after the given number of seconds. >=20 > Signed-off-by: Corey Minyard > --- > qapi-schema.json | 14 +++++---- > qemu-char.c | 88 ++++++++++++++++++++++++++++++++++++++++++++++++= ++++---- > qemu-options.hx | 20 ++++++++----- > 3 files changed, 104 insertions(+), 18 deletions(-) >=20 > diff --git a/qapi-schema.json b/qapi-schema.json > index 689b548..79f7a07 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2648,14 +2648,18 @@ > # @nodelay: #optional set TCP_NODELAY socket option (default: false) > # @telnet: #optional enable telnet protocol on server > # sockets (default: false) > +# @reconnect: #optional If not a server socket, if the socket disconne= ct > +# then reconnect after the given number of seconds. Setting > +# to zero disables this function. (default: 0). Since: 2.2. Looks like I reviewed v1 after you had posted v2; my comments still apply about this being awkward wording. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --arfhEHu5tbSSqglbG7O4KgaMg5VxngNwB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUIIX6AAoJEKeha0olJ0Nq0z0IAKYSyBUElsdTL+s8kFpSD78L nbFwbJcWDhc81qoU2/NYpCfihK8ZtHIdhF5mFTaWKHASPCJlAQa5FtAltCHrJFQY 3D6CAA5SXAFeWdcWkqnrPKlZ6c0jh9lIs9AxE7tcn5mP49jCFnNfkjOf1urmSg+Z +5J6L4bQpA+pTvnVzoTNkbiGoMN1hNxXeyt71gP8ltkzu/NWSmfhI5I2uA5yhsWD bcnxCaTYR5US3xPb1YCIsDZY4/HCf4STjT7MMVHr9b7gLmgPlxLb58Gkx6h01ttK HFyCUS8wiT5aOK45qtt7g6EKboTu0+qnUIut6bcWIMgzowB263k1bOAABgI/Zz0= =o0ec -----END PGP SIGNATURE----- --arfhEHu5tbSSqglbG7O4KgaMg5VxngNwB--