From: Paolo Bonzini <pbonzini@redhat.com>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst
Date: Tue, 23 Sep 2014 00:19:42 +0200 [thread overview]
Message-ID: <5420A07E.9080600@redhat.com> (raw)
In-Reply-To: <1411419461-24390-8-git-send-email-rth@twiddle.net>
Il 22/09/2014 22:57, Richard Henderson ha scritto:
> +QEMU_BUILD_BUG_ON(TCG_TARGET_NB_REGS > 32);
> +QEMU_BUILD_BUG_ON(NB_MMU_MODES > 8);
> +
> typedef struct TCGLabelQemuLdst {
> - bool is_ld:1; /* qemu_ld: true, qemu_st: false */
> - TCGMemOp opc:4;
> - TCGReg addrlo_reg; /* reg index for low word of guest virtual addr */
> - TCGReg addrhi_reg; /* reg index for high word of guest virtual addr */
> - TCGReg datalo_reg; /* reg index for low word to be loaded or stored */
> - TCGReg datahi_reg; /* reg index for high word to be loaded or stored */
> - int mem_index; /* soft MMU memory index */
> + TCGMemOp opc : 4;
> + bool is_ld : 1; /* qemu_ld: true, qemu_st: false */
> + TCGReg addrlo_reg : 5; /* reg index for low word of guest virtual addr */
> + TCGReg addrhi_reg : 5; /* reg index for high word of guest virtual addr */
> + TCGReg datalo_reg : 5; /* reg index for low word to be loaded or stored */
> + TCGReg datahi_reg : 5; /* reg index for high word to be loaded or stored */
> + unsigned mem_index : 3; /* soft MMU memory index */
> + /* 4 bits unused in 32-bit word */
Why? Are there more than 10 or so loads in the typical tb?
Paolo
next prev parent reply other threads:[~2014-09-22 22:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-22 20:57 [Qemu-devel] [PULL 00/11] tcg updates Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 01/11] tcg-sparc: Support addsub2_i64 Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 02/11] tcg-sparc: Use ADDXC in addsub2_i64 Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 03/11] tcg-sparc: Fix setcond_i32 uninitialized value Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 04/11] tcg-sparc: Use ADDXC in setcond_i64 Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 05/11] tcg-sparc: Rename ADDX/SUBX insns Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 06/11] tcg-sparc: Use UMULXHI instruction Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 07/11] tcg: Compress TCGLabelQemuLdst Richard Henderson
2014-09-22 22:19 ` Paolo Bonzini [this message]
2014-09-23 17:48 ` Peter Maydell
2014-09-23 18:42 ` Paolo Bonzini
2014-09-23 18:46 ` Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 08/11] tcg: Move TCG_TYPE_COUNT out of enum TCGType Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 09/11] tcg-aarch64: Use 32-bit loads for qemu_ld_i32 Richard Henderson
2014-09-24 8:20 ` Claudio Fontana
2014-09-24 15:19 ` Richard Henderson
2014-09-25 8:03 ` Claudio Fontana
2014-09-22 20:57 ` [Qemu-devel] [PULL 10/11] qemu/compiler: Define QEMU_ARTIFICIAL Richard Henderson
2014-09-22 20:57 ` [Qemu-devel] [PULL 11/11] tcg: Always enable TCGv type checking Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5420A07E.9080600@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).