From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35968) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWMky-00079k-VS for qemu-devel@nongnu.org; Tue, 23 Sep 2014 05:51:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWMks-0006M5-L5 for qemu-devel@nongnu.org; Tue, 23 Sep 2014 05:51:36 -0400 Received: from mail-qg0-x231.google.com ([2607:f8b0:400d:c04::231]:36939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWMks-0006LN-FY for qemu-devel@nongnu.org; Tue, 23 Sep 2014 05:51:30 -0400 Received: by mail-qg0-f49.google.com with SMTP id q107so4233027qgd.36 for ; Tue, 23 Sep 2014 02:51:24 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54214295.7030701@redhat.com> Date: Tue, 23 Sep 2014 11:51:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <874mz919w5.fsf@troll.troll> <20140709042557.GA10283@grmbl.mre> <20140709104457.GE27615@grmbl.mre> <20140709105620.GG27615@grmbl.mre> <20140711125226.GA17415@grmbl.mre> <8D9E2FF4-9264-49B8-A19C-B71770F9CE11@kamp.de> <20140822035723.GA16198@grmbl.mre> <54058B46.4000305@kamp.de> <54214166.1030601@redhat.com> In-Reply-To: <54214166.1030601@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] migration: catch unknown flag combinations in ram_load List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , Amit Shah Cc: Peter Maydell , Juan Quintela , QEMU Developers , "Dr. David Alan Gilbert" Il 23/09/2014 11:46, Paolo Bonzini ha scritto: > Il 02/09/2014 11:17, Peter Lieven ha scritto: >>>> >>> Juan is back, I'll let him pick it through his tree. >> >> Juan, have you picked this up? > > commit db80facefa62dff42bb50c73b0f03eda5f732b49 > Author: Peter Lieven > Date: Tue Jun 10 11:29:16 2014 +0200 > > migration: catch unknown flags in ram_load > > if a saved vm has unknown flags in the memory data qemu > currently simply ignores this flag and continues which > yields in an unpredictable result. > > This patch catches all unknown flags and aborts the > loading of the vm. Additionally error reports are thrown > if the migration aborts abnormally. > > Signed-off-by: Peter Lieven > Signed-off-by: Juan Quintela Never mind, this is a different patch. Paolo