From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44684)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XWNOx-0003rh-5n
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:33:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XWNOo-0000mq-5B
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:32:55 -0400
Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:33547)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XWNOn-0000mB-Ru
	for qemu-devel@nongnu.org; Tue, 23 Sep 2014 06:32:46 -0400
Received: from /spool/local
	by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Tue, 23 Sep 2014 11:32:39 +0100
Received: from b06cxnps4075.portsmouth.uk.ibm.com
	(d06relay12.portsmouth.uk.ibm.com [9.149.109.197])
	by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 20FF71B0806B
	for <qemu-devel@nongnu.org>; Tue, 23 Sep 2014 11:33:45 +0100 (BST)
Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com
	[9.149.37.228])
	by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s8NAWa5d43122852
	for <qemu-devel@nongnu.org>; Tue, 23 Sep 2014 10:32:36 GMT
Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s8NAWZYh028320
	for <qemu-devel@nongnu.org>; Tue, 23 Sep 2014 04:32:35 -0600
Message-ID: <54214C42.7060900@de.ibm.com>
Date: Tue, 23 Sep 2014 12:32:34 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1411395594-884-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1411395594-884-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] po: fix conflict with %.mo rule in
	rules.mak
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On 09/22/2014 04:19 PM, Paolo Bonzini wrote:
> po/Makefile includes rules.mak to use the nice quiet-command macro.
> However, this also brings in a %.mo rule that breaks "make build".
> Put our own rule before the include, so that it has precedence.
> 
> Reported-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Tested-by: Christian Borntraeger <borntraeger@de.ibm.com>

> ---
>  po/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/po/Makefile b/po/Makefile
> index 1ab241a..b271f79 100644
> --- a/po/Makefile
> +++ b/po/Makefile
> @@ -9,6 +9,9 @@ all:
> 
>  .PHONY:	all build clean install update
> 
> +%.mo: %.po
> +	$(call quiet-command, msgfmt -o $@ $<, "  GEN   $@")
> +
>  -include ../config-host.mak
>  include $(SRC_PATH)/rules.mak
> 
> @@ -38,9 +41,6 @@ install: $(OBJS)
>  	    $(INSTALL) -m644 $$obj $(DESTDIR)$(prefix)/share/locale/$$base/LC_MESSAGES/qemu.mo; \
>  	done
> 
> -%.mo: %.po
> -	$(call quiet-command, msgfmt -o $@ $<, "  GEN   $@")
> -
>  $(PO_PATH)/messages.po: $(SRC_PATH)/ui/gtk.c
>  	$(call quiet-command, ( cd $(SRC_PATH) && \
>            xgettext -o - --from-code=UTF-8 --foreign-user \
>