From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlQb-0005E4-Jc for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:12:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWlQS-0003uw-Q6 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:12:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlQS-0003tU-Ik for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:12:04 -0400 Message-ID: <5422B505.9010601@redhat.com> Date: Wed, 24 Sep 2014 14:11:49 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-22-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-22-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 21/30] scsi: make scsi_bus_new() assign hotplug controller List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, rth@twiddle.net Il 24/09/2014 13:48, Igor Mammedov ha scritto: > it will allow incrementally convert every controller that > creates SCSI bus and supports hotplug to hotplug controller API > > Signed-off-by: Igor Mammedov > --- > hw/scsi/scsi-bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c > index 954c607..33495b6 100644 > --- a/hw/scsi/scsi-bus.c > +++ b/hw/scsi/scsi-bus.c > @@ -92,7 +92,7 @@ void scsi_bus_new(SCSIBus *bus, size_t bus_size, DeviceState *host, > qbus_create_inplace(bus, bus_size, TYPE_SCSI_BUS, host, bus_name); > bus->busnr = next_scsi_bus++; > bus->info = info; > - bus->qbus.allow_hotplug = 1; > + qbus_set_hotplug_handler(BUS(bus), host, &error_abort); > } > > static void scsi_dma_restart_bh(void *opaque) > Reviewed-by: Paolo Bonzini