From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlW4-0002y3-8R for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:17:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWlVx-0005b9-BE for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:17:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlVx-0005Zi-3M for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:17:45 -0400 Message-ID: <5422B659.8020008@redhat.com> Date: Wed, 24 Sep 2014 14:17:29 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-13-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-13-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 12/30] qdev: add simple/generic unplug callback for HotplugHandler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, rth@twiddle.net Il 24/09/2014 13:48, Igor Mammedov ha scritto: > it will be used in shallow conversion from legacy hotplug > mechanism and eventually replace all the uses of old mechanism > DeviceClass->unplug = qdev_simple_unplug_cb() > > Signed-off-by: Igor Mammedov > --- > hw/core/qdev.c | 5 +++++ > include/hw/qdev-core.h | 2 ++ > 2 files changed, 7 insertions(+) > > diff --git a/hw/core/qdev.c b/hw/core/qdev.c > index c89d781..1d1b113 100644 > --- a/hw/core/qdev.c > +++ b/hw/core/qdev.c > @@ -286,6 +286,11 @@ int qdev_simple_unplug_cb(DeviceState *dev) > return 0; > } > > +void qdev_simple_device_unplug_cb(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > + qdev_simple_unplug_cb(dev); > +} > > /* Like qdev_init(), but terminate program via error_report() instead of > returning an error value. This is okay during machine creation. > diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h > index 48a96d2..ba812c5 100644 > --- a/include/hw/qdev-core.h > +++ b/include/hw/qdev-core.h > @@ -265,6 +265,8 @@ void qdev_set_legacy_instance_id(DeviceState *dev, int alias_id, > int required_for_version); > void qdev_unplug(DeviceState *dev, Error **errp); > int qdev_simple_unplug_cb(DeviceState *dev); > +void qdev_simple_device_unplug_cb(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp); > void qdev_machine_creation_done(void); > bool qdev_machine_modified(void); > > Reviewed-by: Paolo Bonzini