From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlcn-0000FC-60 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:24:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWlcg-0007Ez-R9 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:24:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWlcg-0007ES-Iu for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:24:42 -0400 Message-ID: <5422B7FB.5040600@redhat.com> Date: Wed, 24 Sep 2014 14:24:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-18-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-18-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 17/30] virtio-mmio: drop useless bus->allow_hotplug = 0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, rth@twiddle.net Il 24/09/2014 13:48, Igor Mammedov ha scritto: > Bus by default is not hotpluggable. > virtio-mmio-bus and its parent types do not set allow_hotplug > anywhere explicitly, so remove not needed field access > and wrapper along with it. > > Signed-off-by: Igor Mammedov > --- > hw/virtio/virtio-mmio.c | 17 ++--------------- > 1 file changed, 2 insertions(+), 15 deletions(-) > > diff --git a/hw/virtio/virtio-mmio.c b/hw/virtio/virtio-mmio.c > index 18c6e5b..2450c13 100644 > --- a/hw/virtio/virtio-mmio.c > +++ b/hw/virtio/virtio-mmio.c > @@ -89,9 +89,6 @@ typedef struct { > VirtioBusState bus; > } VirtIOMMIOProxy; > > -static void virtio_mmio_bus_new(VirtioBusState *bus, size_t bus_size, > - VirtIOMMIOProxy *dev); > - > static uint64_t virtio_mmio_read(void *opaque, hwaddr offset, unsigned size) > { > VirtIOMMIOProxy *proxy = (VirtIOMMIOProxy *)opaque; > @@ -362,7 +359,8 @@ static void virtio_mmio_realizefn(DeviceState *d, Error **errp) > VirtIOMMIOProxy *proxy = VIRTIO_MMIO(d); > SysBusDevice *sbd = SYS_BUS_DEVICE(d); > > - virtio_mmio_bus_new(&proxy->bus, sizeof(proxy->bus), proxy); > + qbus_create_inplace(&proxy->bus, sizeof(proxy->bus), TYPE_VIRTIO_MMIO_BUS, > + d, NULL); > sysbus_init_irq(sbd, &proxy->irq); > memory_region_init_io(&proxy->iomem, OBJECT(d), &virtio_mem_ops, proxy, > TYPE_VIRTIO_MMIO, 0x200); > @@ -393,17 +391,6 @@ static const TypeInfo virtio_mmio_info = { > > /* virtio-mmio-bus. */ > > -static void virtio_mmio_bus_new(VirtioBusState *bus, size_t bus_size, > - VirtIOMMIOProxy *dev) > -{ > - DeviceState *qdev = DEVICE(dev); > - BusState *qbus; > - > - qbus_create_inplace(bus, bus_size, TYPE_VIRTIO_MMIO_BUS, qdev, NULL); > - qbus = BUS(bus); > - qbus->allow_hotplug = 0; > -} > - > static void virtio_mmio_bus_class_init(ObjectClass *klass, void *data) > { > BusClass *bus_class = BUS_CLASS(klass); > Reviewed-by: Paolo Bonzini