From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWleF-0001pZ-HJ for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:26:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWle9-0007jq-3P for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:26:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12682) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWle8-0007j1-Rg for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:26:13 -0400 Message-ID: <5422B819.6070608@redhat.com> Date: Wed, 24 Sep 2014 14:24:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-19-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-19-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 18/30] s390x: drop not used allow_hotplug in event-facility List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, rth@twiddle.net Il 24/09/2014 13:48, Igor Mammedov ha scritto: > s390-sclp-event-facility creates s390-sclp-events-bus > and immeadiatly sets its allow_hotplug field to 0, > which is NOP since it's already 0 by default. > > Also since BUS is not hotpluggable, it's not possible > to call SCLP_EVENT{ DeviceClass.unplug } callback > from qdev_unplug() making this unreachable code, > so drop it as well. > > Signed-off-by: Igor Mammedov > --- > hw/s390x/event-facility.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c > index 597db34..78da718 100644 > --- a/hw/s390x/event-facility.c > +++ b/hw/s390x/event-facility.c > @@ -333,7 +333,6 @@ static int init_event_facility(SCLPEventFacility *event_facility) > /* Spawn a new bus for SCLP events */ > qbus_create_inplace(&event_facility->sbus, sizeof(event_facility->sbus), > TYPE_SCLP_EVENTS_BUS, sdev, NULL); > - event_facility->sbus.qbus.allow_hotplug = 0; > > quiesce = qdev_create(&event_facility->sbus.qbus, "sclpquiesce"); > if (!quiesce) { > @@ -408,7 +407,6 @@ static void event_class_init(ObjectClass *klass, void *data) > DeviceClass *dc = DEVICE_CLASS(klass); > > dc->bus_type = TYPE_SCLP_EVENTS_BUS; > - dc->unplug = qdev_simple_unplug_cb; > dc->realize = event_realize; > dc->unrealize = event_unrealize; > } > Reviewed-by: Paolo Bonzini