From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWljQ-0005li-P6 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWljJ-00012L-Bo for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:31:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48720) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWljJ-0000zG-4w for qemu-devel@nongnu.org; Wed, 24 Sep 2014 08:31:33 -0400 Message-ID: <5422B995.6040601@redhat.com> Date: Wed, 24 Sep 2014 14:31:17 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-28-git-send-email-imammedo@redhat.com> In-Reply-To: <1411559299-19042-28-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 27/30] usb-storage: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, rth@twiddle.net Il 24/09/2014 13:48, Igor Mammedov ha scritto: > Drop useless hack that disables hotplug on bus, after backend > storage was added to it, by setting "allow_hotplug = 0". Even > if bus is hotpluggable, It won't be possible to add another > SCSI device to bus since its realize will fail early with > error "no free target" in scsi_qdev_realize() method. > > Signed-off-by: Igor Mammedov > --- > hw/usb/dev-storage.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c > index 4ad4ec7..b168d7c 100644 > --- a/hw/usb/dev-storage.c > +++ b/hw/usb/dev-storage.c > @@ -632,7 +632,6 @@ static void usb_msd_realize_storage(USBDevice *dev, Error **errp) > error_propagate(errp, err); > return; > } > - s->bus.qbus.allow_hotplug = 0; > usb_msd_handle_reset(dev); > > if (bdrv_key_required(bs)) { > Reviewed-by: Paolo Bonzini