From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50162) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnHK-0006A8-4w for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWnHE-0002Nx-Tg for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:10:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35015) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnHE-0002NG-G1 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:10:40 -0400 Message-ID: <5422D0D7.2060405@redhat.com> Date: Wed, 24 Sep 2014 08:10:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411165504-18198-1-git-send-email-eblake@redhat.com> <1411165504-18198-11-git-send-email-eblake@redhat.com> <87a95pz0us.fsf@blackfin.pond.sub.org> In-Reply-To: <87a95pz0us.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="99m9NAmAmFAUuLLCkJxapJcAGHrneF4lI" Subject: Re: [Qemu-devel] [PATCH v4 10/19] qapi: Better error messages for duplicated expressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Fam Zheng , qemu-devel@nongnu.org, wenchaoqemu@gmail.com, Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --99m9NAmAmFAUuLLCkJxapJcAGHrneF4lI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/24/2014 05:58 AM, Markus Armbruster wrote: >=20 > We have separate name spaces for events, commands and types. Works for= > me. A single name space would work for me, too. I thought about that too. Our conventions are that commands are all-lower-case, events are ALL_UPPER, and user-defined types are CamelCase - so a single namespace would not have any collisions, except for one case: built-in types like 'int' are also all lower, which collides with commands. But I see no technical reason why we wouldn't be able to generate C code for a command named 'int'. I can go either way, but should probably add a test for a .json file that does {'command':'int'} to test which way we go. Preferences on whether that should be allowed or forbidden? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --99m9NAmAmFAUuLLCkJxapJcAGHrneF4lI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUItDXAAoJEKeha0olJ0NqJNwIAIcwqGrT4i4JaRMh4G9gdXp3 HCNkPCcibuXCZww3u/uh9miEuVM14smnoNZJa47D/bOfB1lR960JsRSnky18aF9C wP3WmXn0cC/dzIx2rv4q7AjdD5h7lbCa8iVgDtD8U15LK2HxPjA0AGzOUDrXirSI ftWnHDb80wZn+lLhO/CJpgqRSGp7j5s5NRIhunnQqiplAHLMDaJUF3h7jxzR6BKU WOnMlFwSvhvfJhIfzZMG6VN/TQC3rIrLBgk7tJYfKw8MrJzJe6ceIcPwpPkfxTcV MGPeOokAttSsD/fi3Roht3/SW133784DdiHk8n7KKx4guSvc5ULqZAHMvUQNeGo= =AZvl -----END PGP SIGNATURE----- --99m9NAmAmFAUuLLCkJxapJcAGHrneF4lI--