From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnx2-0005EK-Sy for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:53:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWnww-0005lq-Jf for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:53:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnww-0005dB-C0 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:53:46 -0400 Message-ID: <5422DAEA.3060208@redhat.com> Date: Wed, 24 Sep 2014 16:53:30 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-16-git-send-email-imammedo@redhat.com> <5422B7BD.9010109@redhat.com> <20140924165144.58f24baf@nial.usersys.redhat.com> In-Reply-To: <20140924165144.58f24baf@nial.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 15/30] virtio-pci: replace BusState.allow_hotplug with hotplug_handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, borntraeger@de.ibm.com, rth@twiddle.net Il 24/09/2014 16:51, Igor Mammedov ha scritto: >> > So this is the opposite of icc-bus; here you need to call the simple >> > hot-unplug callback in the hotplug handler, right? > It's only to workaround bus_add_child() limitation, there is no need > to call unplug callback for child of this bus, since bus and child device > are manually managed by owner of bus without involving hotplug machinery > (via PCIDeviceClass.[init|exit] callbacks). > > Perhaps instead we should just allow to add child to bus is bus_add_child() > regardless whether it's hotpluggable or not and drop this and other > similar patches. Yeah, that would be great and would simply usb-storage as well. Hotpluggability really refers to adding device after initial bring-up of the bus. If the controller is hotplugged together with something below, I don't think that counts. Paolo