From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWoNi-0006DE-Nq for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:21:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWoNc-0004pQ-Jl for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:21:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWoNc-0004ow-Cg for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:21:20 -0400 Message-ID: <5422E160.6010500@redhat.com> Date: Wed, 24 Sep 2014 17:21:04 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411559299-19042-1-git-send-email-imammedo@redhat.com> <1411559299-19042-26-git-send-email-imammedo@redhat.com> <5422B89B.7070805@redhat.com> <20140924171504.7d1e27f9@nial.usersys.redhat.com> In-Reply-To: <20140924171504.7d1e27f9@nial.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 25/30] usb-bot: drop not needed "allow_hotplug = 0" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, borntraeger@de.ibm.com, rth@twiddle.net Il 24/09/2014 17:15, Igor Mammedov ha scritto: > But there is room for improvement here, > it it's possible to error out even earlier if usb-bot would be marked > as not hotpluggable device and add to qdev_device_add() check if > device is hotpluggable even before it's created. That would work too. Gerd, what about usb-uas? Paolo