From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43657)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoZe-0000mi-H4
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:33:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoZZ-0008LS-F9
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:33:46 -0400
Received: from mx1.redhat.com ([209.132.183.28]:21673)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoZZ-0008JM-7G
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:33:41 -0400
Message-ID: <5422E445.5000706@redhat.com>
Date: Wed, 24 Sep 2014 17:33:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411572065-18072-1-git-send-email-benoit.canet@nodalink.com>
	<1411572065-18072-3-git-send-email-benoit.canet@nodalink.com>
In-Reply-To: <1411572065-18072-3-git-send-email-benoit.canet@nodalink.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 2/3] timers: Move
 NANOSECONDS_PER_SECONDS to timer.h for future reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QmVub8OudCBDYW5ldA==?= <benoit.canet@nodalink.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, armbru@redhat.com

Il 24/09/2014 17:21, Beno=C3=AEt Canet ha scritto:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Beno=C3=AEt Canet <benoit.canet@nodalink.com>
> ---
>  include/qemu/throttle.h | 2 --
>  include/qemu/timer.h    | 2 ++
>  2 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
> index 8f9e611..1c639d2 100644
> --- a/include/qemu/throttle.h
> +++ b/include/qemu/throttle.h
> @@ -27,8 +27,6 @@
>  #include "qemu-common.h"
>  #include "qemu/timer.h"
> =20
> -#define NANOSECONDS_PER_SECOND  1000000000
> -
>  typedef enum {
>      THROTTLE_BPS_TOTAL,
>      THROTTLE_BPS_READ,
> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
> index 5f5210d..0884e72 100644
> --- a/include/qemu/timer.h
> +++ b/include/qemu/timer.h
> @@ -5,6 +5,8 @@
>  #include "qemu-common.h"
>  #include "qemu/notify.h"
> =20
> +#define NANOSECONDS_PER_SECOND  1000000000
> +
>  /* timers */
> =20
>  #define SCALE_MS 1000000
>=20

Went through all uses, for the two that matter:

util/throttle.c:    leak =3D (bkt->avg * (double) delta_ns) / NANOSECONDS=
_PER_SECOND;
util/throttle.c:    double wait =3D extra * NANOSECONDS_PER_SECOND;

the other operand is already double.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>