From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoaq-0002ea-0h
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:35:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoaj-0000F5-SE
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:34:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWoaj-0000Dh-KY
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:34:53 -0400
Message-ID: <5422E48E.6080901@redhat.com>
Date: Wed, 24 Sep 2014 17:34:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411559299-19042-1-git-send-email-imammedo@redhat.com>	<1411559299-19042-15-git-send-email-imammedo@redhat.com>	<5422B775.90205@redhat.com>	<20140924163748.18dbc40c@nial.usersys.redhat.com>	<5422DA29.9030806@redhat.com>
	<20140924173049.36e76837@nial.usersys.redhat.com>
In-Reply-To: <20140924173049.36e76837@nial.usersys.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 14/30] target-i386: ICC bus: replace
 BusState.allow_hotplug with hotplug_handler
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: dmitry@daynix.com, mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org, cornelia.huck@de.ibm.com, kraxel@redhat.com, amit.shah@redhat.com, borntraeger@de.ibm.com, rth@twiddle.net

Il 24/09/2014 17:30, Igor Mammedov ha scritto:
>> > Can you make it an error instead?  I guess that's related to the other
>> > question---whether hotplug_handler_plug and/or hotplug_handler_unplug
>> > should return an error if there is no callback.
> For example that would make us in addition to above add fake plug/unplug
> handlers without errors for APIC so it could be realized without error
> when it's created by CPU. (applies to all composite devices).
> 
> Anyway question is moot if we are to drop hotplug assert from bus_add_child().

Ok, I'll wait for v2 then.  Thanks!

Paolo