From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com,
eric.auger@linaro.org, qemu-devel@nongnu.org,
sean.stalley@intel.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 2/7] sysbus: Make devices spawnable via -device
Date: Wed, 24 Sep 2014 17:37:30 +0200 [thread overview]
Message-ID: <5422E53A.7020606@redhat.com> (raw)
In-Reply-To: <1411572143-40345-3-git-send-email-agraf@suse.de>
Il 24/09/2014 17:22, Alexander Graf ha scritto:
> +static int error_on_sysbus_device(SysBusDevice *sbdev, void *opaque)
> +{
> + error_report("Device '%s' can not be handled by this machine",
> + qdev_fw_name(DEVICE(sbdev)));
> + exit(1);
> +}
The firmware name is usually somewhat opaque. Maybe use the class name,
and use
'-device %s' cannot be handled by this machine
? (Note "cannot" is a single word. "can not be handled" means that the
machine may or may not handle it).
Paolo
next prev parent reply other threads:[~2014-09-24 15:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 15:22 [Qemu-devel] [PATCH v3 0/7] Dynamic sysbus device allocation support Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 1/7] sysbus: Add dynamic sysbus device search Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 2/7] sysbus: Make devices spawnable via -device Alexander Graf
2014-09-24 15:37 ` Paolo Bonzini [this message]
2014-09-25 13:17 ` [Qemu-devel] [PATCH v4 " Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 3/7] sysbus: Expose IRQ enumeration helpers Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 4/7] sysbus: Expose MMIO enumeration helper Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 5/7] sysbus: Add new platform bus helper device Alexander Graf
2014-09-26 12:05 ` Paolo Bonzini
2014-09-26 12:26 ` Alexander Graf
2014-09-26 12:44 ` Paolo Bonzini
2014-09-29 8:24 ` Alexander Graf
2014-09-29 8:30 ` Paolo Bonzini
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 6/7] PPC: e500: Support dynamically spawned sysbus devices Alexander Graf
2014-09-24 15:22 ` [Qemu-devel] [PATCH v3 7/7] e500: Add support for eTSEC in device tree Alexander Graf
2014-09-24 15:40 ` [Qemu-devel] [PATCH v3 0/7] Dynamic sysbus device allocation support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422E53A.7020606@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=eric.auger@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=sean.stalley@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).