From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60559)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XWpTv-0003xO-RF
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:32:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XWpN1-0005m1-M2
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:25:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26384)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XWpN1-0005lD-Bn
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:24:47 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8OGOe7G012669
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 24 Sep 2014 12:24:40 -0400
Message-ID: <5422F03E.3080409@redhat.com>
Date: Wed, 24 Sep 2014 18:24:30 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1411551854-23025-1-git-send-email-stefanha@redhat.com>
In-Reply-To: <1411551854-23025-1-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver
	documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>

On 24.09.2014 11:44, Stefan Hajnoczi wrote:
> The blkdebug block driver is undocumented.  Documenting it is worthwhile
> since it offers powerful error injection features that are used by
> qemu-iotests test cases.
>
> This document will make it easier for people to learn about and use
> blkdebug.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> v3:
>   * Fix tab space damage [Eric]
>   * Rephrase event_names[] as full list of events [Eric]
>   * Explain that blkdebug state is not observable from outside [Eric]
>   * Clarify state 0 and state 1 [Eric]
>
> v2:
>   * Added GPL v2 or later license and Red Hat copyright [Eric]
>   * Expanded ini rules file explanation [Paolo]
>   * Added note that errno values depend on the host [Eric]
>
>   docs/blkdebug.txt | 161 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 161 insertions(+)
>   create mode 100644 docs/blkdebug.txt

Reviewed-by: Max Reitz <mreitz@redhat.com>

Maybe I'll add information about blkdebug's QMP interface sometime...