From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWpOd-0008GY-0A for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:26:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWpOW-00068I-NS for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:26:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:10929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWpOW-00065k-FP for qemu-devel@nongnu.org; Wed, 24 Sep 2014 12:26:20 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8OGQEmp018091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 24 Sep 2014 12:26:14 -0400 Message-ID: <5422F0A1.50408@redhat.com> Date: Wed, 24 Sep 2014 12:26:09 -0400 From: John Snow MIME-Version: 1.0 References: <1411551854-23025-1-git-send-email-stefanha@redhat.com> <5422F03E.3080409@redhat.com> In-Reply-To: <5422F03E.3080409@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini On 09/24/2014 12:24 PM, Max Reitz wrote: > On 24.09.2014 11:44, Stefan Hajnoczi wrote: >> The blkdebug block driver is undocumented. Documenting it is worthwhile >> since it offers powerful error injection features that are used by >> qemu-iotests test cases. >> >> This document will make it easier for people to learn about and use >> blkdebug. >> >> Signed-off-by: Stefan Hajnoczi >> --- >> v3: >> * Fix tab space damage [Eric] >> * Rephrase event_names[] as full list of events [Eric] >> * Explain that blkdebug state is not observable from outside [Eric] >> * Clarify state 0 and state 1 [Eric] >> >> v2: >> * Added GPL v2 or later license and Red Hat copyright [Eric] >> * Expanded ini rules file explanation [Paolo] >> * Added note that errno values depend on the host [Eric] >> >> docs/blkdebug.txt | 161 >> ++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 161 insertions(+) >> create mode 100644 docs/blkdebug.txt > > Reviewed-by: Max Reitz > > Maybe I'll add information about blkdebug's QMP interface sometime... If you have the cycles and the knowledge, you definitely should!