From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41652) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWq7S-0001B0-J1 for qemu-devel@nongnu.org; Wed, 24 Sep 2014 13:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWq7N-0002LY-Lg for qemu-devel@nongnu.org; Wed, 24 Sep 2014 13:12:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47203) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWq7N-0002JD-Dw for qemu-devel@nongnu.org; Wed, 24 Sep 2014 13:12:41 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8OHCZHP005244 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 24 Sep 2014 13:12:35 -0400 Message-ID: <5422FB82.9020407@redhat.com> Date: Wed, 24 Sep 2014 11:12:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411551854-23025-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1411551854-23025-1-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xb84TtauMvcc20AMjk0sNPsgSnVmBsUqk" Subject: Re: [Qemu-devel] [PATCH v3] docs: add blkdebug block driver documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , John Snow , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xb84TtauMvcc20AMjk0sNPsgSnVmBsUqk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/24/2014 03:44 AM, Stefan Hajnoczi wrote: > The blkdebug block driver is undocumented. Documenting it is worthwhil= e > since it offers powerful error injection features that are used by > qemu-iotests test cases. >=20 > This document will make it easier for people to learn about and use > blkdebug. >=20 > Signed-off-by: Stefan Hajnoczi > --- > v3: > * Fix tab space damage [Eric] > * Rephrase event_names[] as full list of events [Eric] > * Explain that blkdebug state is not observable from outside [Eric] > * Clarify state 0 and state 1 [Eric] Thanks for the updates. Reviewed-by: Eric Blake > + > +The error injection engine has an integer called the "state" that alwa= ys starts > +initialized to 1. The state integer is internal to blkdebug and canno= t be > +observed from outside but rules can interact with it for powerful matc= hing > +behavior. > + We could always expose it and update the documentation in a later patch. But it is fair to document the current state of things (current docs are always better than no docs :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xb84TtauMvcc20AMjk0sNPsgSnVmBsUqk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUIvuCAAoJEKeha0olJ0Nq78AH/2xyNhNqqJzOM3TOZwcjpd/C f+gKr1pz0G3EmnNPl7nL9ulr+mzUBz7iOkCZmj1MzbhdXCWaUAHXiNBKKqatByh4 RA7b4rVMhnTY2pEPNPoH9Nhi1GLquQbibsf3EcGjqLOv8r0b0cSKpR3RXridpCNP O/B1YP58ae0gskTbo3wi3UO0RSK9/UnQvxSbnFO5BCf6Bng2tvhvAqCivCQmcR6R sTO3JOzMt72xFz286ZumsDgNz7UrpIJiFIEEGMr631eRDcSN1jLJ/sM3kh+XjgGL Zn72WWseKpx5HW/CKW9XDWnpcLOPGapRjSfvYcOCakbp7XQdW90Eqz/q4kYYO7w= =O8n3 -----END PGP SIGNATURE----- --xb84TtauMvcc20AMjk0sNPsgSnVmBsUqk--