From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XX8IX-0003j5-C9 for qemu-devel@nongnu.org; Thu, 25 Sep 2014 08:37:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XX8IT-0007qd-0s for qemu-devel@nongnu.org; Thu, 25 Sep 2014 08:37:25 -0400 Message-ID: <54240C52.3030709@redhat.com> Date: Thu, 25 Sep 2014 06:36:34 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411638384-5844-1-git-send-email-arei.gonglei@huawei.com> <1411638384-5844-5-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411638384-5844-5-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PuhULWlj4HeS6g7cVF0TJck8PamIJ5x7P" Subject: Re: [Qemu-devel] [PATCH 4/4] oslib-posix/win32: convert fprintf/perror to error_report List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, weidong.huang@huawei.com, qemu-trivial@nongnu.org, luonengjun@huawei.com, mjt@tls.msk.ru, armbru@redhat.com, peter.huangpeng@huawei.com, pbonzini@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PuhULWlj4HeS6g7cVF0TJck8PamIJ5x7P Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2014 03:46 AM, arei.gonglei@huawei.com wrote: > From: Gonglei >=20 > Signed-off-by: Gonglei > --- > util/oslib-posix.c | 8 ++++---- > util/oslib-win32.c | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > @@ -380,7 +380,7 @@ void os_mem_prealloc(int fd, char *area, size_t mem= ory) > =20 > ret =3D sigaction(SIGBUS, &act, &oldact); > if (ret) { > - perror("os_mem_prealloc: failed to install signal handler"); > + error_report("os_mem_prealloc: failed to install signal handle= r"); > exit(1); > } > =20 > @@ -390,7 +390,7 @@ void os_mem_prealloc(int fd, char *area, size_t mem= ory) > pthread_sigmask(SIG_UNBLOCK, &set, &oldset); > =20 > if (sigsetjmp(sigjump, 1)) { > - fprintf(stderr, "os_mem_prealloc: failed to preallocate pages\= n"); > + error_report("os_mem_prealloc: failed to preallocate pages"); Another reduction in error message quality. You'll definitely need to respin this series, and at this point, I don't know if you can call it trivial. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PuhULWlj4HeS6g7cVF0TJck8PamIJ5x7P Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUJAxTAAoJEKeha0olJ0NqBnkH/12QEy1C+FOWE0bqcZNpIT5y p06isWQHvHgO2G7g+LFSAYrFmdnK0LFxz/LOlpLrYRmvZ6GcFh9oHMYTACLCmsrq XlwSNArNM2lCJXDB7ciy44zbhs/TqCqNtiT9vrAkHNeusA9qLH2cyGMvnTnpGmLT BOZN96z6egZkA2qtOaektypE/xlZfVNYUsSXtU24rp02H/TKzINtM65z4UbCGptw BN8RNESWAt+2X++dJYMHcJLOk6qLSjGPtX2x4wXqdgKo7DEfcCyZu6fqeFbWQF+0 geJigzjqMLDzO/XDF/msPn8WyJNttAA89CKMdSaW89pNsqTexLMWiE+L9vr2rOA= =m3ET -----END PGP SIGNATURE----- --PuhULWlj4HeS6g7cVF0TJck8PamIJ5x7P--