From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60941)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XX8MD-0006Yl-Nl
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 08:41:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XX8M7-0000R3-Qg
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 08:41:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56974)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XX8M7-0000Py-Fi
	for qemu-devel@nongnu.org; Thu, 25 Sep 2014 08:41:07 -0400
Message-ID: <54240D56.2040105@redhat.com>
Date: Thu, 25 Sep 2014 06:40:54 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1411622627-22110-1-git-send-email-tony@bakeyournoodle.com>
In-Reply-To: <1411622627-22110-1-git-send-email-tony@bakeyournoodle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="V1g6wckHJ8iBjfgwSgeQF39Gwa5hjSWb8"
Subject: Re: [Qemu-devel] [PATCH] block/raw-posix: use seek_hole ahead of
 fiemap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tony Breeds <tony@bakeyournoodle.com>, qemu-devel@nongnu.org
Cc: =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= <pbrady@redhat.com>, Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Michael Steffens <michael_steffens@posteo.de>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--V1g6wckHJ8iBjfgwSgeQF39Gwa5hjSWb8
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/24/2014 11:23 PM, Tony Breeds wrote:
> The command
>   qemu-img convert -O raw inputimage.qcow2 outputimage.raw
>=20
> intermittently creates corrupted output images, when the input image
is not yet fully synchronized to disk.  This patch preferese the use of
seek_hole checks to determine if the sector is present in the disk image.=


s/preferese/prefers/

Please wrap your commit messages to fit in 70 or so columns (so that git
log, which indents messages, is still legible in an 80-column window).

>=20
> While we're there modify try_fiemap() to set FIEMAP_FLAG_SYNC.
>=20
> Reported-By: Michael Steffens <michael_steffens@posteo.de>
> CC: P=C3=A1draig Brady <pbrady@redhat.com>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> ---
>  block/raw-posix.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20

Adding Kevin and Stefan in cc (per scripts/get_maintainer.pl).
Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--V1g6wckHJ8iBjfgwSgeQF39Gwa5hjSWb8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJUJA1WAAoJEKeha0olJ0NqQVYIAKZmPjiWAXv5R/MpwLoioIm0
2AysSGJBOMeAp3SLz1cEw8H+/L5HklINL62PZk8vQThz66kclpILtUNARF7cE/w7
dnKHNKKrYRRWAm1rcouXZzMhtaD5pXkoqCJnU8Dc/jPEMFUe6l+KpUSYscvPnVPb
IqK9E6B+pP/78xJAleRge0+ZW73xq3atWDM0PJFSyOftV09AEankGtqwmNyIleEh
ss/9wadVJvzocNyAsrYJ0OF3k5zIM3+mztAsCxQkhunHfwScZ7DFBQPGw5zlRWW7
+1iwRPPTGZ0JPV6Icni2FLvkbmWJjgkknkqRNlwbzQYHdC/4k54T5jO8Hs0q1DI=
=X2w2
-----END PGP SIGNATURE-----

--V1g6wckHJ8iBjfgwSgeQF39Gwa5hjSWb8--