From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, Olaf Hering <olaf@aepfle.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Cole Robinson <crobinso@redhat.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel@nongnu.org, Stefan Weil <sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info
Date: Thu, 25 Sep 2014 15:51:44 +0200 [thread overview]
Message-ID: <54241DF0.8050001@redhat.com> (raw)
In-Reply-To: <20140925104954.GE19882@stefanha-thinkpad.redhat.com>
Il 25/09/2014 12:49, Stefan Hajnoczi ha scritto:
> On Thu, Sep 25, 2014 at 10:06:35AM +0200, Olaf Hering wrote:
>> During code review for xen I noticed that --enable-debug-info
>> would still strip the binaries because strip_opt= defaults to
>> yes. If --enable-debug-info is passed to configure it has to be
>> assumed that not only the compiled binaries have debugsymbols,
>> also the installed binaries should keep the symbols. The
>> requirement to pass also --disable-strip looks odd.
>
> Perhaps package maintainers rely on installed binaries not having
> debug symbols?
If so, that should be taken care of by the distribution.
Of course, a distribution is free to separate the debug info and ship
it as a separate package; in that case, it makes sense to distribute
stripped binaries.
But I think discarding symbols on "make install" is in general a bad
idea, especially for long-lived processes such as QEMU where you often
have non-reproducible bugs. If symbols are gone, even the simplest
bug becomes basically impossible to diagnose from a core dump.
The GNU Makefile standards have "make install" and "make
install-strip" targets. It would be nice to add "make install-strip"
and at the same time flip the default from --enable-strip to
--disable-strip.
Paolo
next prev parent reply other threads:[~2014-09-25 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 8:06 [Qemu-devel] [PATCH] build: preserve debug symbols with --enable-debug-info Olaf Hering
2014-09-25 10:36 ` Peter Maydell
2014-09-25 10:47 ` Olaf Hering
2014-09-25 10:51 ` Peter Maydell
2014-09-25 10:49 ` Stefan Hajnoczi
2014-09-25 10:55 ` Olaf Hering
2014-09-25 11:05 ` Michael Tokarev
2014-09-25 13:51 ` Paolo Bonzini [this message]
2014-10-02 15:39 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54241DF0.8050001@redhat.com \
--to=pbonzini@redhat.com \
--cc=crobinso@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=olaf@aepfle.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).