From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXC8y-0003Vt-BC for qemu-devel@nongnu.org; Thu, 25 Sep 2014 12:43:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXC8t-0002Fy-Aj for qemu-devel@nongnu.org; Thu, 25 Sep 2014 12:43:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXC8t-0002AS-2O for qemu-devel@nongnu.org; Thu, 25 Sep 2014 12:43:43 -0400 Message-ID: <542443BA.8080301@redhat.com> Date: Thu, 25 Sep 2014 10:32:58 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411165504-18198-1-git-send-email-eblake@redhat.com> <1411165504-18198-13-git-send-email-eblake@redhat.com> <87h9zw9mqy.fsf@blackfin.pond.sub.org> <54241EB3.5080309@redhat.com> <87k34rwufb.fsf@blackfin.pond.sub.org> In-Reply-To: <87k34rwufb.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AtU3A1c29k44qacrpDMKdnhdl8b7TuHlt" Subject: Re: [Qemu-devel] [PATCH v4 12/19] qapi: Add some type check tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Luiz Capitulino , Fam Zheng , qemu-devel@nongnu.org, wenchaoqemu@gmail.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AtU3A1c29k44qacrpDMKdnhdl8b7TuHlt Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/25/2014 10:12 AM, Markus Armbruster wrote: >>> Do we want to permit anything but a complex type for 'returns'? >> >> Sadly, yes. We have existing commands that do just that. I already >> documented that new commands should avoid it (it's not extensible). >=20 > If we care, we can whitelist the existing offenders, and reject new > offenders. Also a good idea. The whitelist may grow over time, but forcing a developer to modify the whitelist calls attention to their action :) I'll add that to my v5 queue. Thanks again for a thought-provoking revie= w. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AtU3A1c29k44qacrpDMKdnhdl8b7TuHlt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUJEO6AAoJEKeha0olJ0NqOckIAIBijVhBDqMfa6NXXdkMu7Ts YPaohD+iSofNQmsFTpM7CFteLShZp+gLXSuLzN3UIg+hmfQyplUr2fCajU8nu0Zv P15xPM5nH0XtesSp5uwp4viN38/yDLNceZid39rczvWEzULF3jyqlN6NiHEoel9z JBKGqmGfHL/D7AGDwM2juPYj8c31oMXnLgRFyc5+GmmKi3SPVYlDiWc+22RLqJQ8 +QGzv5YEu0nGD/73rxT4w8sDElvOIIBkkarC86RHrPtZ0gR/zEo4KWD1afqnNJ0D gifXKH63wE3SyIlFBKOXMLbHI/M4+5CEv5lrAWKbCaDDHu+AcWEcmtJRTzaZ+2I= =r9pR -----END PGP SIGNATURE----- --AtU3A1c29k44qacrpDMKdnhdl8b7TuHlt--