From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iohandler: Add Linux implementation of iohandler GSource
Date: Fri, 26 Sep 2014 09:42:02 +0200 [thread overview]
Message-ID: <542518CA.9020209@redhat.com> (raw)
In-Reply-To: <20140926012351.GA1680@fam-t430.nay.redhat.com>
Il 26/09/2014 03:23, Fam Zheng ha scritto:
> > Also, as an extra optimization perhaps you can make a second list with
> > iohandlers that were modified or have a read_poll handler, and only call
> > iohandler_get_events on that one.
>
> Sounds good, but I need to benchmark it to tell :)
>
> There isn't a lot of computation if there is no read_poll.
>
> > Perhaps this together lowers the cost of epoll enough to more easily
> > reach the break-even point.
>
> Dynamic swithing between ppoll and epoll shoudn't be hard to implement, but I'm
> not sure how to write the condition.
Perhaps just a count of the number of polled file descriptors.
> Anyway, do you think it is a good idea?
It depends. I think first of all we need to profile it for low file
descriptor counts, and see if obvious sources of overhead stand out
either in QEMU or in the kernel...
There's time anyway, since we also need a Win32 implementation.
Paolo
prev parent reply other threads:[~2014-09-26 7:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 17:21 [Qemu-devel] [PATCH 0/2] iohandler: Convert to GSource and use epoll on Linux Fam Zheng
2014-09-25 17:21 ` [Qemu-devel] [PATCH 1/2] iohandler: Convert I/O handler to GSource Fam Zheng
2014-09-25 17:21 ` [Qemu-devel] [PATCH 2/2] iohandler: Add Linux implementation of iohandler GSource Fam Zheng
2014-09-25 19:45 ` Paolo Bonzini
2014-09-26 1:23 ` Fam Zheng
2014-09-26 7:42 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542518CA.9020209@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).