From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38958)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXQk9-00006A-8d
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 04:19:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXQk1-0005ZK-45
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 04:19:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:58757)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXQk0-0005Ye-Rr
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 04:19:01 -0400
Message-ID: <54252169.4040402@redhat.com>
Date: Fri, 26 Sep 2014 10:18:49 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411672074-21031-1-git-send-email-borntraeger@de.ibm.com>
In-Reply-To: <1411672074-21031-1-git-send-email-borntraeger@de.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] kvm/valgrind: dont mark memory as
	initialized
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: qemu-devel@nongnu.org

Il 25/09/2014 21:07, Christian Borntraeger ha scritto:
> since commit 7dda5dc82a77 ("migration: initialize RAM to zero") the
> guest memory is defined zero. No need to call valgrind on guest memory.
> This reverts commit 62fe83318d2f ("qemu: Use valgrind annotations to
> mark kvm guest memory as defined") thus speeding up kvm start if
> <includedir>/valgrind/valgrind.h is available.
> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>  configure |    3 +--
>  kvm-all.c |    7 -------
>  2 files changed, 1 insertions(+), 9 deletions(-)
> 
> diff --git a/configure b/configure
> index eb9cbcd..3dfb339 100755
> --- a/configure
> +++ b/configure
> @@ -3968,12 +3968,11 @@ else
>  fi
>  
>  ########################################
> -# check if we have valgrind/valgrind.h and valgrind/memcheck.h
> +# check if we have valgrind/valgrind.h
>  
>  valgrind_h=no
>  cat > $TMPC << EOF
>  #include <valgrind/valgrind.h>
> -#include <valgrind/memcheck.h>
>  int main(void) {
>    return 0;
>  }
> diff --git a/kvm-all.c b/kvm-all.c
> index 8b9e66d..cf822a4 100644
> --- a/kvm-all.c
> +++ b/kvm-all.c
> @@ -44,10 +44,6 @@
>  #include <sys/eventfd.h>
>  #endif
>  
> -#ifdef CONFIG_VALGRIND_H
> -#include <valgrind/memcheck.h>
> -#endif
> -
>  /* KVM uses PAGE_SIZE in its definition of COALESCED_MMIO_MAX */
>  #define PAGE_SIZE TARGET_PAGE_SIZE
>  
> @@ -1954,9 +1950,6 @@ int kvm_has_intx_set_mask(void)
>  
>  void kvm_setup_guest_memory(void *start, size_t size)
>  {
> -#ifdef CONFIG_VALGRIND_H
> -    VALGRIND_MAKE_MEM_DEFINED(start, size);
> -#endif
>      if (!kvm_has_sync_mmu()) {
>          int ret = qemu_madvise(start, size, QEMU_MADV_DONTFORK);
>  
> 

Thanks, applying to uq/master.

Paolo