From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRsV-000551-MZ for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:31:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXRsQ-0008I2-3G for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:31:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:41491 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXRsP-0008Hk-Mc for qemu-devel@nongnu.org; Fri, 26 Sep 2014 05:31:46 -0400 Message-ID: <5425327B.4020603@suse.de> Date: Fri, 26 Sep 2014 11:31:39 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <06fb909de78f8a8f2ae6f3a2ff39a564584da359.1411019133.git.zhugh.fnst@cn.fujitsu.com> In-Reply-To: <06fb909de78f8a8f2ae6f3a2ff39a564584da359.1411019133.git.zhugh.fnst@cn.fujitsu.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v1 2/3] qom: export object_property_is_child() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Zhu Guihua , qemu-devel@nongnu.org, aliguori@amazon.com, lcapitulino@redhat.com Cc: hutao@cn.fujitsu.com, isimatu.yasuaki@jp.fujitsu.com, tangchen@cn.fujitsu.com Am 18.09.2014 um 09:53 schrieb Zhu Guihua: > Export object_property_is_child() to let it be invoked in other places. >=20 > Signed-off-by: Zhu Guihua > --- > include/qom/object.h | 1 + > qom/object.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/include/qom/object.h b/include/qom/object.h > index 5d55889..8f27b7c 100644 > --- a/include/qom/object.h > +++ b/include/qom/object.h > @@ -1302,4 +1302,5 @@ Object *container_get(Object *root, const char *p= ath); > =20 > void *object_property_get_opaque(ObjectProperty *prop, Error **errp); > =20 > +bool object_property_is_child(ObjectProperty *prop); You already dropped one white line in the previous patch, now you're leaving no spacing at all. Please always leave at least one before the header guard. Regards, Andreas > #endif > diff --git a/qom/object.c b/qom/object.c > index 00a25e0..8de2599 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -351,7 +351,7 @@ void object_initialize(void *data, size_t size, con= st char *typename) > object_initialize_with_type(data, size, type); > } > =20 > -static inline bool object_property_is_child(ObjectProperty *prop) > +bool object_property_is_child(ObjectProperty *prop) > { > return strstart(prop->type, "child<", NULL); > } >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg