From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Andreas Färber" <afaerber@suse.de>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>,
Richard Henderson <rth@twiddle.net>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors
Date: Fri, 26 Sep 2014 12:49:06 +0200 [thread overview]
Message-ID: <542544A2.6030600@de.ibm.com> (raw)
In-Reply-To: <542541B6.1000009@suse.de>
On 09/26/2014 12:36 PM, Andreas Färber wrote:
>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f)
>> s->id.ciw[i].count = qemu_get_be16(f);
>> }
>> s->ccw_fmt_1 = qemu_get_byte(f);
>> + s->ccw_no_data_cnt = qemu_get_byte(f);
>> return 0;
>> }
>>
>
> You need to bump the version saved if you add fields (same as VMState),
> and on load you need to check the version for whether to load the field
> (or deny loading).
Alex brough up the same thing. As the cpu migration code is not yet upstream (in prep right now) we concluded that this is still ok.
http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01094.html
next prev parent reply other threads:[~2014-09-26 10:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 12:14 [Qemu-devel] [PULL 0/3] s390x/kvm: some fixes and cleanups Christian Borntraeger
2014-09-23 12:14 ` [Qemu-devel] [PULL 1/3] s390x: remove duplicate defines in SCLP code Christian Borntraeger
2014-09-23 12:14 ` [Qemu-devel] [PULL 2/3] s390x/css: support format-0 ccws Christian Borntraeger
2014-09-26 10:41 ` Andreas Färber
2014-09-23 12:14 ` [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors Christian Borntraeger
2014-09-26 10:36 ` Andreas Färber
2014-09-26 10:49 ` Christian Borntraeger [this message]
2014-09-26 11:18 ` Andreas Färber
2014-09-23 13:42 ` [Qemu-devel] [PULL 0/3] s390x/kvm: some fixes and cleanups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542544A2.6030600@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).