From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45370)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XXT5Y-0006it-Dz
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:49:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XXT5Q-0002yc-Ox
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:49:24 -0400
Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:56013)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1XXT5Q-0002yG-Fc
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 06:49:16 -0400
Received: from /spool/local
	by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 26 Sep 2014 11:49:10 +0100
Received: from b06cxnps4076.portsmouth.uk.ibm.com
	(d06relay13.portsmouth.uk.ibm.com [9.149.109.198])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 20F9717D8041
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 11:51:16 +0100 (BST)
Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com
	[9.149.37.216])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id s8QAn8Oe30015612
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 10:49:08 GMT
Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id s8QAn6T8004097
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 04:49:07 -0600
Message-ID: <542544A2.6030600@de.ibm.com>
Date: Fri, 26 Sep 2014 12:49:06 +0200
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1411474456-12226-1-git-send-email-borntraeger@de.ibm.com>
	<1411474456-12226-4-git-send-email-borntraeger@de.ibm.com>
	<542541B6.1000009@suse.de>
In-Reply-To: <542541B6.1000009@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Peter Maydell <peter.maydell@linaro.org>, Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: Jens Freimann <jfrei@linux.vnet.ibm.com>, Richard Henderson <rth@twiddle.net>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

On 09/26/2014 12:36 PM, Andreas Färber wrote:

>> @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f)
>>          s->id.ciw[i].count = qemu_get_be16(f);
>>      }
>>      s->ccw_fmt_1 = qemu_get_byte(f);
>> +    s->ccw_no_data_cnt = qemu_get_byte(f);
>>      return 0;
>>  }
>>  
> 
> You need to bump the version saved if you add fields (same as VMState),
> and on load you need to check the version for whether to load the field
> (or deny loading).

Alex brough up the same thing. As the cpu migration code is not yet upstream (in prep right now) we concluded that this is still ok.

http://lists.gnu.org/archive/html/qemu-devel/2014-09/msg01094.html