From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46390)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXVCA-0007AO-RS
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:04:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXVC2-00070f-EW
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:04:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64444)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XXVC2-000707-6u
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:04:14 -0400
Message-ID: <54256444.90601@redhat.com>
Date: Fri, 26 Sep 2014 15:04:04 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1411703316.git.peter.crosthwaite@xilinx.com>
	<49bd5a0a38ec4aed5248f5cf7afb47ee9ec722ab.1411703316.git.peter.crosthwaite@xilinx.com>
In-Reply-To: <49bd5a0a38ec4aed5248f5cf7afb47ee9ec722ab.1411703316.git.peter.crosthwaite@xilinx.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qom v3 07/14] qdev: gpio: Re-impement
 qdev_connect_gpio QOM style
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, agraf@suse.de, afaerber@suse.de

Il 26/09/2014 07:20, Peter Crosthwaite ha scritto:
> +    if (pin) {
> +        object_property_add_child(qdev_get_machine(), "non-qdev-gpio[*]",
> +                                  OBJECT(pin), NULL);
> +    }

So here is when you're using the "do not abort if not a child" behavior.
 It deserves at least a comment, because it's not obvious.

Paolo