From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXVPW-0006cF-QZ for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXVPP-0002wl-BQ for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:18:10 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46639 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXVPP-0002wM-5U for qemu-devel@nongnu.org; Fri, 26 Sep 2014 09:18:03 -0400 Message-ID: <54256783.4020600@suse.de> Date: Fri, 26 Sep 2014 15:17:55 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <5425667C.5020300@redhat.com> In-Reply-To: <5425667C.5020300@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom v3 00/14] GPIO/IRQ QOMification: Phase 2 - Getting rid of SYSBUS IRQs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, agraf@suse.de Am 26.09.2014 um 15:13 schrieb Paolo Bonzini: > Il 26/09/2014 07:16, Peter Crosthwaite ha scritto: >> Hi All, >> >> So phase one was the QOMification of qemu_irq. This is the next step. >> We start to setup GPIOs as proper QOM objects. Inputs are child object= s >> of their device. Outputs are settable Links and connection is made >> via proper setting of a QOM link. >> >> We then cleanup Sysbus to simply re-use device level GPIOs and get rid >> of it's special IRQ handling code. >> >> CHanged since v2: >> Remove num_irq from sysbus (P14) >> Removed out of tree deps. >> Changed since v1: >> Addressed Alex review >> Dropped IRQ g_new0 changes >> >> >> >> Peter Crosthwaite (14): >> qdev: gpio: Don't allow name share between I and O >> qdev: gpio: Register GPIO inputs as child objects >> qdev: gpio: Register GPIO outputs as QOM links >> qmp: qstring: Handle NULL strings >> qom: Allow clearing of a Link property >> qom: Demote already-has-a-parent to a regular error >> qdev: gpio: Re-impement qdev_connect_gpio QOM style >> qdev: gpio: Add API for intercepting a GPIO >> qtest/irq: Rework IRQ interception >> irq: Remove qemu_irq_intercept_out >> qdev: gpio: delete NamedGPIOList::out >> qdev: gpio: Remove qdev_init_gpio_out x1 restriction >> qdev: gpio: Define qdev_pass_gpios() >> sysbus: Use TYPE_DEVICE GPIO functionality >> >> hw/core/irq.c | 8 +---- >> hw/core/qdev.c | 90 +++++++++++++++++++++++++++++++++++++++++= +++++---- >> hw/core/sysbus.c | 20 ++--------- >> include/hw/irq.h | 1 - >> include/hw/qdev-core.h | 6 +++- >> include/hw/sysbus.h | 7 ++-- >> qobject/qstring.c | 12 ++++--- >> qom/object.c | 10 ++++-- >> qtest.c | 15 ++++++--- >> 9 files changed, 120 insertions(+), 49 deletions(-) >> >=20 > Apart from the couple of patches I replied to, >=20 > Reviewed-by: Paolo Bonzini >=20 > Alex, do you want to pick it up and send it together with your sysbus > patches? I had started picking up the initial ones from v2 after Alex' ping... Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg