From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59832)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XXXCU-000722-Rw
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:13:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XXXCK-0004yq-Ug
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:12:50 -0400
Received: from mail-we0-x22d.google.com ([2a00:1450:400c:c03::22d]:41327)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XXXCK-0004wH-L8
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:12:40 -0400
Received: by mail-we0-f173.google.com with SMTP id p10so274429wes.32
	for <qemu-devel@nongnu.org>; Fri, 26 Sep 2014 08:12:35 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542580A1.9070102@redhat.com>
Date: Fri, 26 Sep 2014 17:05:05 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1409344310-5441-1-git-send-email-ehabkost@redhat.com>
	<1409344310-5441-12-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1409344310-5441-12-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 11/17] accel: Remove tcg_available()
	function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Michael Mueller <mimu@linux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, Marcel Apfelbaum <marcel.a@redhat.com>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, "Jason J. Herne" <jjherne@linux.vnet.ibm.com>, =?windows-1252?Q?Andreas_?= =?windows-1252?Q?F=E4rber?= <afaerber@suse.de>

Il 29/08/2014 22:31, Eduardo Habkost ha scritto:
> As the function always return 1, it is not needed anymore.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  arch_init.c                | 5 -----
>  hw/core/accel.c            | 1 -
>  include/sysemu/arch_init.h | 1 -
>  3 files changed, 7 deletions(-)
> 
> diff --git a/arch_init.c b/arch_init.c
> index 28ece76..4cd21c9 100644
> --- a/arch_init.c
> +++ b/arch_init.c
> @@ -1335,11 +1335,6 @@ void cpudef_init(void)
>  #endif
>  }
>  
> -int tcg_available(void)
> -{
> -    return 1;
> -}
> -
>  int kvm_available(void)
>  {
>  #ifdef CONFIG_KVM
> diff --git a/hw/core/accel.c b/hw/core/accel.c
> index 5853551..aeb779a 100644
> --- a/hw/core/accel.c
> +++ b/hw/core/accel.c
> @@ -119,7 +119,6 @@ static void tcg_accel_class_init(ObjectClass *oc, void *data)
>  {
>      AccelClass *ac = ACCEL_CLASS(oc);
>      ac->name = "tcg";
> -    ac->available = tcg_available;
>      ac->init = tcg_init;
>      ac->allowed = &tcg_allowed;
>  }
> diff --git a/include/sysemu/arch_init.h b/include/sysemu/arch_init.h
> index 182d48d..5968837 100644
> --- a/include/sysemu/arch_init.h
> +++ b/include/sysemu/arch_init.h
> @@ -32,7 +32,6 @@ void do_smbios_option(QemuOpts *opts);
>  void ram_mig_init(void);
>  void cpudef_init(void);
>  void audio_init(void);
> -int tcg_available(void);
>  int kvm_available(void);
>  int xen_available(void);
>  
> 

When we will support disabling of TCG, we will move the registration to
translate-all.c so the function will not exist anyway.

Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo