From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXXKE-0001lA-FK for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:20:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXXK5-0007Nr-DA for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:20:50 -0400 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:58477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXXK5-0007M4-5w for qemu-devel@nongnu.org; Fri, 26 Sep 2014 11:20:41 -0400 Received: by mail-wg0-f50.google.com with SMTP id l18so9166425wgh.9 for ; Fri, 26 Sep 2014 08:20:35 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54258440.3060203@redhat.com> Date: Fri, 26 Sep 2014 17:20:32 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411676309-20218-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1411676309-20218-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 00/10] Target-specific unit test support, add unit tests for target-i386/cpu.c code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Igor Mammedov , =?windows-1252?Q?Andreas_F=E4r?= =?windows-1252?Q?ber?= Il 25/09/2014 22:18, Eduardo Habkost ha scritto: > This is an attempt to write unit tests for the target-i386/cpu.c code. By now, I > just implemented 3 simple test cases, to ensure X86CPU objects can be created, > and to ensure the CPU features are set properly depending on the CPU model > table. + qemu-log.o \ + qom/object.o qom/qom-qobject.o qom/cpu.o qom/container.o \ + hw/core/qdev.o hw/core/qdev-properties.o hw/core/irq.o hw/core/fw-path-provider.o hw/core/hotplug.o \ + vmstate.o qemu-file.o $(util-obj-y) \ + x86_64-softmmu/cpus.o x86_64-softmmu/target-i386/machine.o \ + tests/vl-stub.o tests/x86-stub.o tests/coroutine-stub.o tests/monitor-stub.o tests/aio-stub.o tests/timer-stub.o tests/block-stub.o \ + stubs/reset.o stubs/sysbus.o stubs/vmstate.o stubs/fdset-remove-fd.o stubs/mon-printf.o stubs/qtest.o stubs/vm-stop.o Do you really need cpus.c? That's what brings in most dependencies, and everything else should be included in libqemustub.a. Also, util-obj-y should be replaced with libqemuutil.a In any case, most of these files are not needed by the linux-user version of cpu.c, so I would need to know what exactly forces you to include each of the files. Also, would it be possible to do these tests via qtest and qom-get/qom-set? That said, please feel free to send patches 1-3 now, via qemu-trivial. Thanks, Paolo