From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57470)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XXYxO-0005Jn-EA
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:05:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XXYxJ-0003kn-VN
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:05:22 -0400
Received: from mx1.redhat.com ([209.132.183.28]:37584)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1XXYxJ-0003kT-Ou
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:05:17 -0400
Message-ID: <54259CC2.20508@redhat.com>
Date: Fri, 26 Sep 2014 19:05:06 +0200
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1411622627-22110-1-git-send-email-tony@bakeyournoodle.com>
	<1411686852-26487-1-git-send-email-tony@bakeyournoodle.com>
In-Reply-To: <1411686852-26487-1-git-send-email-tony@bakeyournoodle.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk
 corruption in try_fiemap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tony Breeds <tony@bakeyournoodle.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= <pbrady@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 26.09.2014 01:14, Tony Breeds wrote:
> Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter.
>
> Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl.  This has
> the downside of significantly reducing performance.
>
> Reported-By: Michael Steffens <michael_steffens@posteo.de>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: P=C3=A1draig Brady <pbrady@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> ---
> Changes since v1:
>   - split in to 2 patches
>   - tried to make the commit messages better
>
>   block/raw-posix.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Max Reitz <mreitz@redhat.com>