From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58275)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XXZ1c-0000e3-Ob
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:09:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XXZ1Y-0004o0-Gp
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:09:44 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45540)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1XXZ1Y-0004nk-5m
	for qemu-devel@nongnu.org; Fri, 26 Sep 2014 13:09:40 -0400
Message-ID: <54259DCA.3080408@redhat.com>
Date: Fri, 26 Sep 2014 11:09:30 -0600
From: Eric Blake <eblake@redhat.com>
MIME-Version: 1.0
References: <1411622627-22110-1-git-send-email-tony@bakeyournoodle.com>
	<1411686852-26487-1-git-send-email-tony@bakeyournoodle.com>
In-Reply-To: <1411686852-26487-1-git-send-email-tony@bakeyournoodle.com>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="tEWp7j2OPcCmMNMfn37fbSCrWIrqC4HdD"
Subject: Re: [Qemu-devel] [PATCH v2 1/2] block/raw-posix: Fix disk
	corruption in try_fiemap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tony Breeds <tony@bakeyournoodle.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= <pbrady@redhat.com>, Markus Armbruster <armbru@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Max Reitz <mreitz@redhat.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--tEWp7j2OPcCmMNMfn37fbSCrWIrqC4HdD
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 09/25/2014 05:14 PM, Tony Breeds wrote:
> Using fiemap without FIEMAP_FLAG_SYNC is a known corrupter.
>=20
> Add the FIEMAP_FLAG_SYNC flag to the FS_IOC_FIEMAP ioctl.  This has
> the downside of significantly reducing performance.
>=20
> Reported-By: Michael Steffens <michael_steffens@posteo.de>
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Markus Armbruster <armbru@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Max Reitz <mreitz@redhat.com>
> Cc: P=C3=A1draig Brady <pbrady@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> ---
> Changes since v1:
>  - split in to 2 patches
>  - tried to make the commit messages better
>=20
>  block/raw-posix.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

[you buried your patches in deep reply to a longer thread, making them
harder to find; in the future, you can just send a v2 as a new top-level
thread]

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--tEWp7j2OPcCmMNMfn37fbSCrWIrqC4HdD
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg

iQEcBAEBCAAGBQJUJZ3KAAoJEKeha0olJ0NqkHkH/3tFoJsiwwzHTSvOTG3oShdw
znU0++rFfji3oorOw4AiFf7ZuCWfwPbUGQsnFOv9HhBkCHtNGTVrUZROF2KgwwML
QNPcRzyR9P3V0TgEXCk5U59e/yzX8RPH/VwkLu1dABcSACgnqkthlPbmGZL/3Tkk
ICH9sDZ3qWGkZ+5bKB/njVesqPSSN8h7DKToH4oJHju8nbGRttFxnhZFet4ZqAs7
aweIbxq9HM9CqirszaefnXSytU9Li4RXnA6LX3aHBvD/l7UjI/Y6C/FOJxLcsZeJ
SC0ThLQEtwZ9IyhBbth4f2Eat/YHrskCR7nE/e1n3x81yM/LM+mlpngOeiFBVgQ=
=tcsB
-----END PGP SIGNATURE-----

--tEWp7j2OPcCmMNMfn37fbSCrWIrqC4HdD--