From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44636) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XY7p4-0004nt-I2 for qemu-devel@nongnu.org; Sun, 28 Sep 2014 02:19:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XY7oz-0006Kx-IN for qemu-devel@nongnu.org; Sun, 28 Sep 2014 02:19:06 -0400 Received: from mail-pd0-x236.google.com ([2607:f8b0:400e:c02::236]:52964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XY7oy-0006K5-Ew for qemu-devel@nongnu.org; Sun, 28 Sep 2014 02:19:01 -0400 Received: by mail-pd0-f182.google.com with SMTP id y10so3480435pdj.41 for ; Sat, 27 Sep 2014 23:18:54 -0700 (PDT) Sender: Richard Henderson Message-ID: <5427A84A.8010600@twiddle.net> Date: Sat, 27 Sep 2014 23:18:50 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1411829891-24866-1-git-send-email-kbastian@mail.uni-paderborn.de> <1411829891-24866-2-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1411829891-24866-2-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/5] target-tricore: Cleanup and Bugfixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bastian Koppelmann , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 09/27/2014 07:58 AM, Bastian Koppelmann wrote: > Move FCX loading of save_context_ to caller functions, for STLCX, STUCX insn to use those functions. > Move FCX storing of restore_context_ to caller functions, for LDLCX, LDUCX insn to use those functions. > Remove do_raise_exception function, which caused clang to emit a warning. > Fix: save_context_lower now saves a[11] instead of PSW. > Fix: MASK_OP_ABSB_BPOS starting at wrong offset. > > Signed-off-by: Bastian Koppelmann Reviewed-by: Richard Henderson r~