From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYCId-0004R2-TT for qemu-devel@nongnu.org; Sun, 28 Sep 2014 07:06:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYCIZ-0007iT-3h for qemu-devel@nongnu.org; Sun, 28 Sep 2014 07:05:55 -0400 Received: from mail.uni-paderborn.de ([131.234.142.9]:34561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYCIY-0007i6-Sr for qemu-devel@nongnu.org; Sun, 28 Sep 2014 07:05:51 -0400 Message-ID: <5427F988.2080706@mail.uni-paderborn.de> Date: Sun, 28 Sep 2014 13:05:28 +0100 From: Bastian Koppelmann MIME-Version: 1.0 References: <1411829891-24866-1-git-send-email-kbastian@mail.uni-paderborn.de> <1411829891-24866-5-git-send-email-kbastian@mail.uni-paderborn.de> <54279B11.2030907@twiddle.net> In-Reply-To: <54279B11.2030907@twiddle.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/5] target-tricore: Add instructions of BIT opcode format List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 09/28/2014 06:22 AM, Richard Henderson wrote: >> + case OPC2_32_BIT_XNOR_T: >> + gen_bit_1op(cpu_gpr_d[r3], cpu_gpr_d[r1], cpu_gpr_d[r2], >> + pos1, pos2, &tcg_gen_xor_tl); > tcg_gen_eqv_tl > I often don't use the optimal tcg-frontend operation, since the documentation I mostly use is http://wiki.qemu.org/Documentation/TCG/frontend-ops, which is outdated. That said, I'm willing to update the documentation to include all the latest tcg-ops. Richard, would you be willing to review those changes? Thanks, Bastian