From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XYVyv-0008Uv-Lg
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 04:06:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XYVyq-0002Fw-Qx
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 04:06:53 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:64483)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <zhang.zhanghailiang@huawei.com>) id 1XYVyq-0002Eo-4a
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 04:06:48 -0400
Message-ID: <542912FE.8020900@huawei.com>
Date: Mon, 29 Sep 2014 16:06:22 +0800
From: zhanghailiang <zhang.zhanghailiang@huawei.com>
MIME-Version: 1.0
References: <1411108984-4380-1-git-send-email-zhang.zhanghailiang@huawei.com>	<1411108984-4380-2-git-send-email-zhang.zhanghailiang@huawei.com>
	<87bnpyvpdq.fsf@blackfin.pond.sub.org>
In-Reply-To: <87bnpyvpdq.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v6 1/2] dump: let dump_error return error
 info to caller
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: lersek@redhat.com, lcapitulino@redhat.com, luonengjun@huawei.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

On 2014/9/29 15:48, Markus Armbruster wrote:
> zhanghailiang <zhang.zhanghailiang@huawei.com> writes:
>
>> The second parameter of dump_error is unused, but one purpose of
>> using this function is to report the error info.
>>
>> Use error_set to return the error info to the caller.
>>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>
> The commit message doesn't explain this patch's benefit clearly.
> Suggest:
>
>      dump: Propagate errors into qmp_dump_guest_memory()
>
>      The code calls dump_error() on error, and even passes it a suitable
>      message.  However, the message is thrown away, and its callers pass
>      up only success/failure.  All qmp_dump_guest_memory() can do is set
>      a generic error.
>
>      Propagate the errors properly, so qmp_dump_guest_memory() can return
>      a more useful error.
>
> With a commit message like that:
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
>

OK, Will fix like that, and submit V7, thanks very much;)