From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v4 7/7] virtio-scsi: Handle TMF request cancellation asynchronously
Date: Mon, 29 Sep 2014 12:11:08 +0200 [thread overview]
Message-ID: <5429303C.6080100@redhat.com> (raw)
In-Reply-To: <1411868881-19110-8-git-send-email-famz@redhat.com>
Il 28/09/2014 03:48, Fam Zheng ha scritto:
> + virtio_scsi_complete_req(req);
> + } else {
> + assert(r = -EINPROGRESS);
> + }
> }
= instead of == here.
Apart from this, the patch looks good. Thanks!
Paolo
next prev parent reply other threads:[~2014-09-29 10:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 1:47 [Qemu-devel] [PATCH v4 0/7] virtio-scsi: Asynchronous cancellation Fam Zheng
2014-09-28 1:47 ` [Qemu-devel] [PATCH v4 1/7] scsi: Drop scsi_req_abort Fam Zheng
2014-09-28 1:47 ` [Qemu-devel] [PATCH v4 2/7] scsi-generic: Handle canceled request in scsi_command_complete Fam Zheng
2014-09-28 1:47 ` [Qemu-devel] [PATCH v4 3/7] scsi-bus: Unify request unref in scsi_req_cancel Fam Zheng
2014-09-28 1:47 ` [Qemu-devel] [PATCH v4 4/7] scsi: Drop SCSIReqOps.cancel_io Fam Zheng
2014-09-28 1:47 ` [Qemu-devel] [PATCH v4 5/7] scsi: Introduce scsi_req_cancel_complete Fam Zheng
2014-09-28 1:48 ` [Qemu-devel] [PATCH v4 6/7] scsi: Introduce scsi_req_cancel_async Fam Zheng
2014-09-28 1:48 ` [Qemu-devel] [PATCH v4 7/7] virtio-scsi: Handle TMF request cancellation asynchronously Fam Zheng
2014-09-29 10:11 ` Paolo Bonzini [this message]
2014-09-29 10:56 ` Paolo Bonzini
2014-09-30 2:27 ` Fam Zheng
2014-09-30 2:48 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5429303C.6080100@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).