From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYht-0004wI-J2 for qemu-devel@nongnu.org; Mon, 29 Sep 2014 07:01:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYYhk-0004uq-F7 for qemu-devel@nongnu.org; Mon, 29 Sep 2014 07:01:29 -0400 Received: from mail-wg0-x22f.google.com ([2a00:1450:400c:c00::22f]:40718) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYYhk-0004uU-8y for qemu-devel@nongnu.org; Mon, 29 Sep 2014 07:01:20 -0400 Received: by mail-wg0-f47.google.com with SMTP id b13so1493534wgh.6 for ; Mon, 29 Sep 2014 04:01:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <54293BD8.9020207@redhat.com> Date: Mon, 29 Sep 2014 13:00:40 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411723721-20484-1-git-send-email-imammedo@redhat.com> <1411723721-20484-20-git-send-email-imammedo@redhat.com> In-Reply-To: <1411723721-20484-20-git-send-email-imammedo@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 19/36] target-i386: ICC bus: drop BusState.allow_hotplug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , qemu-devel@nongnu.org Cc: dmitry@daynix.com, borntraeger@de.ibm.com, mst@redhat.com, agraf@suse.de, amit.shah@redhat.com, kraxel@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net Il 26/09/2014 11:28, Igor Mammedov ha scritto: > since bus_add_child() no longer cares if BUS is hotpluggable > or not, there is no need in setting allow_hotplug field. > > Signed-off-by: Igor Mammedov > --- > hw/cpu/icc_bus.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/hw/cpu/icc_bus.c b/hw/cpu/icc_bus.c > index 7f44c59..9575fd6 100644 > --- a/hw/cpu/icc_bus.c > +++ b/hw/cpu/icc_bus.c > @@ -24,18 +24,10 @@ > > /* icc-bridge implementation */ > > -static void icc_bus_init(Object *obj) > -{ > - BusState *b = BUS(obj); > - > - b->allow_hotplug = true; > -} > - > static const TypeInfo icc_bus_info = { > .name = TYPE_ICC_BUS, > .parent = TYPE_BUS, > .instance_size = sizeof(ICCBus), > - .instance_init = icc_bus_init, > }; > > > Reviewed-by: Paolo Bonzini