From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYcAN-00030C-IH for qemu-devel@nongnu.org; Mon, 29 Sep 2014 10:43:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYcAI-0005hI-Ks for qemu-devel@nongnu.org; Mon, 29 Sep 2014 10:43:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYcAI-0005ga-Ca for qemu-devel@nongnu.org; Mon, 29 Sep 2014 10:43:02 -0400 Message-ID: <54296FE4.407@redhat.com> Date: Mon, 29 Sep 2014 08:42:44 -0600 From: Eric Blake MIME-Version: 1.0 References: <1411983695-7910-1-git-send-email-dgilbert@redhat.com> In-Reply-To: <1411983695-7910-1-git-send-email-dgilbert@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PB985GJwfgarTcxAhpwmAsUwkwIUUkKLq" Subject: Re: [Qemu-devel] [PATCH v5 0/2] In memory QEMUFile List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" , qemu-devel@nongnu.org Cc: sanidhya.iiith@gmail.com, joel.schopp@amd.com, stefanb@linux.vnet.ibm.com, arei.gonglei@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --PB985GJwfgarTcxAhpwmAsUwkwIUUkKLq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/29/2014 03:41 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" >=20 > This patch-pair adds the QEMUSizedBuffer based in-memory QEMUFile > written by Stefan Berger and Joel Schopp. I've made some > fixes and modified the existing test-vmstate to use it for some test ca= ses. >=20 > While there's nothing other than test cases using it yet, I think > it's worth going in by itself, since I'm using it in two separate > patchsets (postcopy and visitor/BER) and Sanidhya uses it in > the periodic vmstate test world. In addition both microcheckpointing a= nd > COLO have similar but independent implementations (although they both > have some extra-gotcha's so it might not be possible to reuse it), and > there was another implementation of the same thing in the Yabusame Post= copy > world. Thus it seems best to put in, if only to stop people writing ye= t > another implementation. >=20 > Dave >=20 > v5: > Fixes from Eric's comments; including a memory leak in an error path Looks correct to me, so my R-b is valid. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --PB985GJwfgarTcxAhpwmAsUwkwIUUkKLq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUKW/kAAoJEKeha0olJ0NqHAUH/3Yn5PrzSX4gA6MvoEeouQ7J 4JlFo1g8GYoNdvYm7C3io0ic08cI8XQWXd7lfVmwPfz7ugZq3sZbB7TjlJFakTP+ Hhj5daz3wMOwcV6KNud9oWD24re5qumiX5GTY19K9N0b/Akw6QQXcGtJrIYSllsW fbC5BGucGatKsS5Q8K9SYl8STnWjT0jVeOH6zx/DOBQiOibqLbPuYzjmsRoQVPhf zccyAQNG7FEpF6by5BeazWsC9mBLesbCpiZzBlKZRfJ26cGrzdlR/sME8QmfChYn AQaZl2x6o5MXu4oeEpOFZNdm/xeJxjlDgZUKhDUCjY/nOF+4qSMgLdBrAM3mbnQ= =MVdB -----END PGP SIGNATURE----- --PB985GJwfgarTcxAhpwmAsUwkwIUUkKLq--