From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59890)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYiuL-0007pB-Pz
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 17:55:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYiuF-0002om-Q8
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 17:55:01 -0400
Received: from mail-we0-x235.google.com ([2a00:1450:400c:c03::235]:35918)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYiuF-0002oC-Jm
	for qemu-devel@nongnu.org; Mon, 29 Sep 2014 17:54:55 -0400
Received: by mail-we0-f181.google.com with SMTP id u57so2385826wes.12
	for <qemu-devel@nongnu.org>; Mon, 29 Sep 2014 14:54:48 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5429D527.5060008@redhat.com>
Date: Mon, 29 Sep 2014 23:54:47 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411572065-18072-1-git-send-email-benoit.canet@nodalink.com>	<1411572065-18072-3-git-send-email-benoit.canet@nodalink.com>	<5422E459.1070708@redhat.com>
	<20140929160444.GC26702@nodalink.com>
In-Reply-To: <20140929160444.GC26702@nodalink.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v3 2/3] timers: Move
 NANOSECONDS_PER_SECONDS to timer.h for future reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?windows-1252?Q?Beno=EEt_Canet?= <benoit.canet@nodalink.com>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, armbru@redhat.com

Il 29/09/2014 18:04, Benoît Canet ha scritto:
> On Wed, Sep 24, 2014 at 05:33:45PM +0200, Paolo Bonzini wrote:
>> Il 24/09/2014 17:21, Benoît Canet ha scritto:
>>> Reviewed-by: Eric Blake <eblake@redhat.com>
>>> Signed-off-by: Benoît Canet <benoit.canet@nodalink.com>
>>> ---
>>>  include/qemu/throttle.h | 2 --
>>>  include/qemu/timer.h    | 2 ++
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/qemu/throttle.h b/include/qemu/throttle.h
>>> index 8f9e611..1c639d2 100644
>>> --- a/include/qemu/throttle.h
>>> +++ b/include/qemu/throttle.h
>>> @@ -27,8 +27,6 @@
>>>  #include "qemu-common.h"
>>>  #include "qemu/timer.h"
>>>  
>>> -#define NANOSECONDS_PER_SECOND  1000000000
>>> -
>>>  typedef enum {
>>>      THROTTLE_BPS_TOTAL,
>>>      THROTTLE_BPS_READ,
>>> diff --git a/include/qemu/timer.h b/include/qemu/timer.h
>>> index 5f5210d..0884e72 100644
>>> --- a/include/qemu/timer.h
>>> +++ b/include/qemu/timer.h
>>> @@ -5,6 +5,8 @@
>>>  #include "qemu-common.h"
>>>  #include "qemu/notify.h"
>>>  
>>> +#define NANOSECONDS_PER_SECOND  1000000000
>>> +
>>>  /* timers */
>>>  
>>>  #define SCALE_MS 1000000
>>>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> :)
> 
> Two rev by for one commit are better than one but does this belong to
> the third commit ? :)

The rev-bys belong to the first and second.  The third's on my list...

Paolo