From: Paolo Bonzini <pbonzini@redhat.com>
To: zwu.kernel@gmail.com, qemu-devel@nongnu.org
Cc: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
Subject: Re: [Qemu-devel] [PATCH] libcacard: fix compile error on glib2-2.12.3-4.el5
Date: Tue, 30 Sep 2014 08:53:26 +0200 [thread overview]
Message-ID: <542A5366.60109@redhat.com> (raw)
In-Reply-To: <1411780438-7472-1-git-send-email-zwu.kernel@gmail.com>
Il 27/09/2014 03:13, zwu.kernel@gmail.com ha scritto:
> From: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
>
> lt LINK libcacard.la
> CC libcacard/vscclient.o
> lt LINK vscclient
> /usr/bin/ld: -f may not be used without -shared
> collect2: ld returned 1 exit status
> make: *** [vscclient] Error 1
>
> Signed-off-by: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
> ---
> libcacard/Makefile | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 0e7903f..40f7a28 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -1,5 +1,6 @@
> libcacard_includedir=$(includedir)/cacard
> -
> +CFLAGS += -fPIC
> +LDFLAGS += $(LDFLAGS_SHARED)
> TOOLS += vscclient$(EXESUF)
This is included into the main Makefile, so please do the change there.
Paolo
> # objects linked into a shared library, built with libtool with -fPIC if required
>
prev parent reply other threads:[~2014-09-30 6:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 1:13 [Qemu-devel] [PATCH] libcacard: fix compile error on glib2-2.12.3-4.el5 zwu.kernel
2014-09-30 6:53 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A5366.60109@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhiyong.wzy@alibaba-inc.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).