From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51763)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYrOr-0000hY-Id
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 02:59:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYrOm-000258-Jb
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 02:59:05 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:63995)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XYrOm-00022a-EY
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 02:59:00 -0400
Received: by mail-wg0-f42.google.com with SMTP id z12so3944497wgg.13
	for <qemu-devel@nongnu.org>; Mon, 29 Sep 2014 23:58:54 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542A5366.60109@redhat.com>
Date: Tue, 30 Sep 2014 08:53:26 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411780438-7472-1-git-send-email-zwu.kernel@gmail.com>
In-Reply-To: <1411780438-7472-1-git-send-email-zwu.kernel@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] libcacard: fix compile error on
	glib2-2.12.3-4.el5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: zwu.kernel@gmail.com, qemu-devel@nongnu.org
Cc: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>

Il 27/09/2014 03:13, zwu.kernel@gmail.com ha scritto:
> From: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
> 
> lt LINK libcacard.la
>   CC    libcacard/vscclient.o
> lt LINK vscclient
> /usr/bin/ld: -f may not be used without -shared
> collect2: ld returned 1 exit status
> make: *** [vscclient] Error 1
> 
> Signed-off-by: Zhi Yong Wu <zhiyong.wzy@alibaba-inc.com>
> ---
>  libcacard/Makefile |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 0e7903f..40f7a28 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -1,5 +1,6 @@
>  libcacard_includedir=$(includedir)/cacard
> -
> +CFLAGS += -fPIC
> +LDFLAGS += $(LDFLAGS_SHARED)
>  TOOLS += vscclient$(EXESUF)

This is included into the main Makefile, so please do the change there.

Paolo

>  # objects linked into a shared library, built with libtool with -fPIC if required
>