From: Paolo Bonzini <pbonzini@redhat.com>
To: arei.gonglei@huawei.com, qemu-devel@nongnu.org
Cc: weidong.huang@huawei.com, armbru@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message
Date: Tue, 30 Sep 2014 09:12:14 +0200 [thread overview]
Message-ID: <542A57CE.9040000@redhat.com> (raw)
In-Reply-To: <1411045577-1152-1-git-send-email-arei.gonglei@huawei.com>
Il 18/09/2014 15:06, arei.gonglei@huawei.com ha scritto:
> we will lose the error message. Using error_report
> to report it.
>
> Cc: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
> v4:
> fix typo in the subject (Eric), Thanks.
> v3:
> fix some typos/grammar issues (Eric) and add 'R-by' tag
> v2:
> using original condition instead of local_err (Markus)
> ---
> hw/pci/pci-hotplug-old.c | 5 ++++-
Hi Gonglei, since this is for an HMP-only command, please use
qerror_report_err like qemu_pci_hot_add_nic does.
Sorry for not noticing this patch earlier.
Paolo
next prev parent reply other threads:[~2014-09-30 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 13:06 [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message arei.gonglei
2014-09-29 2:53 ` Gonglei (Arei)
2014-09-30 7:12 ` Paolo Bonzini [this message]
2014-09-30 7:17 ` Gonglei (Arei)
2014-09-30 8:12 ` Markus Armbruster
2014-09-30 8:18 ` Paolo Bonzini
2014-09-30 8:23 ` Gonglei (Arei)
2014-09-30 9:37 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A57CE.9040000@redhat.com \
--to=pbonzini@redhat.com \
--cc=arei.gonglei@huawei.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=weidong.huang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).