From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54322) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYrbr-0004Mm-Us for qemu-devel@nongnu.org; Tue, 30 Sep 2014 03:12:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYrbg-0005IH-7k for qemu-devel@nongnu.org; Tue, 30 Sep 2014 03:12:31 -0400 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:60033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYrbg-0005Gf-0i for qemu-devel@nongnu.org; Tue, 30 Sep 2014 03:12:20 -0400 Received: by mail-wg0-f42.google.com with SMTP id z12so3961649wgg.13 for ; Tue, 30 Sep 2014 00:12:14 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <542A57CE.9040000@redhat.com> Date: Tue, 30 Sep 2014 09:12:14 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1411045577-1152-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1411045577-1152-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] pci-hotplug-old: avoid losing error message List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: weidong.huang@huawei.com, armbru@redhat.com, mst@redhat.com Il 18/09/2014 15:06, arei.gonglei@huawei.com ha scritto: > we will lose the error message. Using error_report > to report it. > > Cc: Markus Armbruster > Signed-off-by: Gonglei > Reviewed-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > v4: > fix typo in the subject (Eric), Thanks. > v3: > fix some typos/grammar issues (Eric) and add 'R-by' tag > v2: > using original condition instead of local_err (Markus) > --- > hw/pci/pci-hotplug-old.c | 5 ++++- Hi Gonglei, since this is for an HMP-only command, please use qerror_report_err like qemu_pci_hot_add_nic does. Sorry for not noticing this patch earlier. Paolo